search

zemirco / csrf-express-angular

CSRF protection example app built with Express and Angular
18 stars 8 forks source link

Express CSRF syntax change #3

Open felipe-pereira opened 9 years ago

felipe-pereira commented 9 years ago

I followed the steps on your post but found an invalid csrf token error, searched a bit and got the answer here.

As an improvement of that already great post maybe you could include some reference to that change.

Thanks for your work!.

zemirco commented 9 years ago

Would you like to write a pull request?

felipe-pereira commented 9 years ago

Not sure if I could do that since my comment was about updating your post (the one linked in the readme), english is not my native lang so maybe this part wasn't clear enough (well, remove the maybe, I had to read my post a few times to remember what it was about)

zemirco commented 9 years ago

I meant a pull request for this repo updating the code inside https://github.com/zemirco/csrf-express-angular/blob/master/app.js.

felipe-pereira commented 9 years ago

Got it, I could, but at this moment I'm bit short on time and resources to test it properly, the proposed change would require not only a modification to the file you just linked, but also an express update, so it wouldn't be nice of me to pull request that without testing. I would just update the blog post to mention that slight change for newer versions, this app here still would work based on that express version.