search

zemirco / json2csv

Convert json to csv with column titles
http://zemirco.github.io/json2csv
MIT License
2.71k stars 365 forks source link

No BOM character at the beginning of the csv #186

Closed AuroreM closed 7 years ago

AuroreM commented 7 years ago

I used this library to create csv then opened with Excel and I encountered some issue with special characters : image

I found that I had to add the BOM character U+FEFF at the beginning of the CSV string. I've got a branch ready for a pull request to add a --with-BOM option :

image

But I can not push my branch. Could you help me please ? (It's my first contribution to an open source repo :))

4ian commented 7 years ago

But I can not push my branch. Could you help me please ? (It's my first contribution to an open source repo :))

The way to submit pull requests with GitHub is to Fork the repository:

image

You'll have a fork for your username (https://github.com/AuroreM/json2csv). Then git clone your fork and do the changes in it (or add https://github.com/AuroreM/json2csv as a remote to your existing git repository where you've made the changes. Then push to that remote).

Once you have your branch pushed in your fork you can open a Pull Request and GitHub will show your branch or your fork. :)

AuroreM commented 7 years ago

Thanks @4ian, the Pull Request is opened : https://github.com/zemirco/json2csv/pull/187 :)

knownasilya commented 7 years ago

Ah, missed this issue. Thanks for catching this.