zemirco / json2csv

Convert json to csv with column titles
http://zemirco.github.io/json2csv
MIT License
2.72k stars 362 forks source link

fix: don't mutate original object in unset #499

Closed juanjoDiaz closed 4 years ago

juanjoDiaz commented 4 years ago

Fix small issue introduced in #496 which might modify the original data

martinfrancois commented 4 years ago

Consider adding a unit test which makes a deep copy before running parse, then compare the input to parse with the deep copy from before (checking for equality), to prevent regressions in the future 😃

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a0f3ef48b3270edd454487c51e21ecf8b9d4af2d on juanjoDiaz:fix_unset_v5 into b071eb1d3ae14d3a1d645230787f2c45766dae5e on zemirco:v5.

martinfrancois commented 4 years ago

Thanks for merging @knownasilya , is there a chance we can have a release soon, so we can get rid of our workaround that's in place for the moment?

knownasilya commented 4 years ago

Released

martinfrancois commented 4 years ago

Thanks a lot! 👍