search

zemirco / json2csv

Convert json to csv with column titles
http://zemirco.github.io/json2csv
MIT License
2.72k stars 362 forks source link

Move CI to GitHub Actions #501

Closed juanjoDiaz closed 2 years ago

juanjoDiaz commented 4 years ago

Travis is becoming reaaaaaally slow and I don't see any advantage compared to having everything here in GitHub. I already have it set up for some of my other projects so it's trivial for me to port it. Opinions?

Also, I could add a workflow to automatically deploy to npm whenever we publish a new release in GitHub. My only problem with that is that an admin needs to put the NPM token in the secrets so the action can automatically. Who is an admin of this repo? @knownasilya? or still @zemirco? What do you guys think?

knownasilya commented 4 years ago

For it 👍 @zemirco would have to do it

juanjoDiaz commented 2 years ago

Hi @zemirco any news on this?

I just did the same with other of my projects and I'd like to move this to GitHub actions. At the moment Travis is broken and we do not really have CI in place because of this.

I understand if you don't want to put your NPM key since you don't control this repo. I'll be happy to do so. But I'd need you to transfer the repo to me and make me an owner in NPM. After all I've pretty much rewritten the whole thing and made all the code contribution during the last few years.

knownasilya commented 2 years ago

I have access to npm so we could move repos if there is no response, but we would lose all of the non file data (issues, stars, etc).

zemirco commented 2 years ago

Hey all,

thank you very much for your hard work over the last years. I really appreciate it! You're really good maintainers. Our third child was born last October and there was only limited time for me working on open source projects. Things are improving right now so let's tackle this problem.

I will add GitHub actions and move the workflow away from Travis.

knownasilya commented 2 years ago

Congrats on number 3! We are expecting our third as well.

juanjoDiaz commented 2 years ago

Done as part of v6 in a separate repo