search

zemirco / json2csv

Convert json to csv with column titles
http://zemirco.github.io/json2csv
MIT License
2.71k stars 366 forks source link

Add GitHub actions #562

Closed juanjoDiaz closed 2 years ago

juanjoDiaz commented 2 years ago

The error in the pipeline is caused by metalsmith-start which is a dependency of docpress.

I have no idea of why docpress pull from github directly instead of using NPM.

"metalsmith-start": "github:rstacruz/metalsmith-start#e88a7cdbb20aac1db176c121b429008073d8e9eb"

juanjoDiaz commented 2 years ago

Obviously some work is needed to make this work on Windows. Expected...

But we can solve the auto-deploy question in the meantime.

knownasilya commented 2 years ago

Not sure what's up with the test runner on Windows, keeps terminating.

juanjoDiaz commented 2 years ago

Sorry for the delay. I was busy finalizing my Ph.D.

The build is now fixed to work in both Windows and Linux.

Now comes the real question. Are we happy automating the releases fully?

@knownasilya can you describe the steps that you follow to release? To make sure that I don't miss anything.

What do we do with the NPM_TOKEN? Either @zemirco adds it or he transfer the project and I add it.

knownasilya commented 2 years ago

I'm totally fine with automating the release. I run this script https://github.com/zemirco/json2csv/blob/master/package.json#L40 and it works great as long as commits follow the correct conventions.

knownasilya commented 2 years ago

I believe we'd need a new way to publish the docs to the site, and probably good to remove Node 12 (since it's eol). Otherwise I think v6 is good to go.

juanjoDiaz commented 2 years ago

I believe we'd need a new way to publish the docs to the site, and probably good to remove Node 12 (since it's eol).

We do indeed. I have new documentation built in docsify which takes care of this.

Otherwise I think v6 is good to go.

I don't think so. Apart from the new docs, I also have a new API for WHATWG Streams (the new WebStreams). I also have some changes to 100% isolate Node stuff from pure JS stuff. And most importantly, the pipelines are not ready because @zemirco is being a blocker regarding the NPM_TOKEN.

The last time that he spoke it was because I had to reach out to him by email to get a response, and the response was a PR with a GitHub action YAML that was not what I asked for nor what we needed. This time I'm not going to chase him. He created this repo and if he wants to keep it without contributing that's perfectly fine. Unfortunately, this setup doesn't work for me, so I'll fork next week and add a new PR here stating that v6 will be published as a new library.