zemirco / json2csv

Convert json to csv with column titles
http://zemirco.github.io/json2csv
MIT License
2.71k stars 366 forks source link

Fix typo in eol option for stringQuoteOnlyIfNecessary #570

Closed jdleesmiller closed 2 years ago

jdleesmiller commented 2 years ago

It looks like there is a typo in the check for opts.eol in the stringQuoteOnlyIfNecessary formatter. This fixes the typo and adds a test.

(There may be a better way to test this... I could not commit a fixture CSV file with CRLF newlines.)

juanjoDiaz commented 2 years ago

Good catch @jdleesmiller!

Sorry, but I didn't noticed this PR and just fixed this issue while fixing #562