zemuldo / iso_8583

:credit_card::moneybag: JavaScript library for iso 8583 messaging. Handles message validation & conversion between interfaces using iso 8583 standard. Contributors are welcome.
https://zemuldo.github.io/iso_8583/
MIT License
85 stars 50 forks source link

First contribution #132

Open jlaustill opened 11 months ago

jlaustill commented 11 months ago

workerB

This PR adds some error handling around the ISO format for healthcare and the ability to leave the 127 field un-expanded and encoded in a customer encoding.

mcfriend99 commented 9 months ago

@zemuldo Need help with the review??

zemuldo commented 9 months ago

@zemuldo Need help with the review??

@mcfriend99 Please go ahead. I also plan to have a look this weekend.

zemuldo commented 9 months ago

@jlaustill Please update the change to enable the GitHub actions matrix when you can. I plan to review the PR this weekend.

jlaustill commented 9 months ago

@zemuldo Sorry, I didn't notice the contribution readme :) I'm working with iso packets from Fiserve, and they do a LOT of non standard stuff. So I have this library wrapped by another class that does a tons more to the iso after parsing. Keep that in mind as you review :)

zemuldo commented 9 months ago

Please update the branch you have for tests to run.