Closed sarmadhamdani02 closed 1 year ago
Hi @sarmadhamdani02, thanks for the PR.
I donβt think the hierarchy of this nav bar is appropriate given that the text size of menu items is noticeably larger than the rest of the UI elements (which should be prioritized). Screenshot below. Additionally, the horizontal rule is too prominent. How else might we add that division, do we need it at all?
Also, please run npm test
locally and address the linting issues.
Due to #379 we donβt have proper CI running on the repo.
I ran the command locally and this was the output:
$ npm test
> zen-audio-player@1.1.0 pretest
> npm run stylelint:css && npm run lint
> zen-audio-player@1.1.0 stylelint:css
> stylelint css/*.css
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
css/styles.css
4:3 β Expected indentation of 0 spaces indentation
21:8 β Expected single space before "{" block-opening-brace-space-before
28:32 β Expected "#777" to be "#777777" color-hex-length
32:3 β Unexpected whitespace at end of line no-eol-whitespace
35:24 β Expected single space before "{" block-opening-brace-space-before
43:1 β Expected no more than 2 empty lines max-empty-lines
52:28 β Expected single space before "{" block-opening-brace-space-before
61:18 β Expected double quotes string-quotes
64:21 β Unexpected unit length-zero-no-unit
70:34 β Expected single space before "{" block-opening-brace-space-before
71:12 β Unexpected named color "white" color-named
72:23 β Unexpected named color "black" color-named
74:4 β Unexpected whitespace at end of line no-eol-whitespace
77:35 β Expected single space before "{" block-opening-brace-space-before
78:12 β Unexpected named color "black" color-named
79:23 β Unexpected named color "white" color-named
83:26 β Expected single space before "{" block-opening-brace-space-before
93:18 β Expected double quotes string-quotes
96:21 β Unexpected unit length-zero-no-unit
98:4 β Unexpected whitespace at end of line no-eol-whitespace
101:28 β Expected single space before "{" block-opening-brace-space-before
102:12 β Expected "#222" to be "#222222" color-hex-length
107:32 β Expected single space before "{" block-opening-brace-space-before
108:23 β Unexpected named color "black" color-named
112:34 β Expected single space before "{" block-opening-brace-space-before
113:12 β Unexpected named color "white" color-named
116:33 β Expected single space before "{" block-opening-brace-space-before
117:12 β Unexpected named color "black" color-named
118:23 β Unexpected named color "white" color-named
123:1 β Expected empty line before rule rule-empty-line-before
123:13 β Expected single space before "{" block-opening-brace-space-before
140:13 β Unexpected empty block block-no-empty
141:8 β Unexpected whitespace at end of line no-eol-whitespace
143:4 β Unexpected whitespace at end of line no-eol-whitespace
144:25 β Expected single space before "{" block-opening-brace-space-before
146:6 β Expected indentation of 4 spaces indentation
148:6 β Expected indentation of 4 spaces indentation
148:19 β Expected single space before "{" block-opening-brace-space-before
150:6 β Expected indentation of 4 spaces indentation
152:6 β Expected indentation of 4 spaces indentation
152:42 β Expected single space before "{" block-opening-brace-space-before
154:6 β Expected indentation of 4 spaces indentation
155:6 β Expected empty line before rule rule-empty-line-before
155:6 β Expected indentation of 4 spaces indentation
155:40 β Expected single space before "{" block-opening-brace-space-before
157:6 β Expected indentation of 4 spaces indentation
159:5 β Unexpected whitespace at end of line no-eol-whitespace
160:1 β Expected indentation of 4 spaces indentation
160:22 β Expected single space before "{" block-opening-brace-space-before
161:5 β Expected indentation of 8 spaces indentation
161:12 β Expected "#777" to be "#777777" color-hex-length
162:5 β Expected indentation of 8 spaces indentation
164:1 β Expected indentation of 4 spaces indentation
258:24 β Expected newline after ";" declaration-block-semicolon-newline-after
258:24 β Unexpected whitespace at end of line no-eol-whitespace
378:3 β Unexpected whitespace at end of line no-eol-whitespace
393:8 β Unexpected whitespace at end of line no-eol-whitespace
Thanks for reviewing @shakeelmohamed Ok, let me decrease the font size of navBar items and I think I should remove the horizontal line π
Hey @shakeelmohamed π
Hey @shakeelmohamed π!
In the last few commits, I have added the following changes to the UI,
Kindly review it as soon as possible ππ
In the latest commit, I have added a dark mode and added some icons for the dark mode in the top right corner and some animation for the dark mode.
The only problem I am facing is an npm error saying "'gsap' is not defined" (I have used the GSAP library for animation and that is why I used gsap keyword in many places in the code). Not sure how should I remove this error. Apart from this everything is pretty much fine.