Open PraveenRaj1833 opened 10 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
zen-audio-player-github-io | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 23, 2023 1:59pm |
@PraveenRaj1833 Exciting to see this PR come through, thank you! It’s on my list to review
Thank you @shakeelmohamed, It was quite a good learning for me. Waiting for your suggestions on this. Also as I was working on this today for long time, I think the 10,000 units free quota for today might be exceeded. It will renew tomorrow Pacific time. Sorry for over-usage 😅.
Hi @shakeelmohamed, did you get a chance to review the code?
@PraveenRaj1833, I’m just getting to this now.
Can you provide a quick outline of the different user flows through this feature? I’ll need an hour or so to play with this either way since it’s a significant code change.
Related to the user flows, are you interested in writing automated tests for this feature?
hi @PraveenRaj1833, are you interested in writing some tests for this awesome feature? I haven’t reviewed the code yet, would be great if we can get some automated testing in place to ensure nothing breaks down the line.
Motivation and Context
Types of changes
What types of changes does your code introduce? Check all the boxes that apply:
Description
Final checklist:
Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!