zen-audio-player / zen-audio-player.github.io

Listen to YouTube videos, without the distracting visuals.
https://zen-audio-player.github.io/
MIT License
228 stars 180 forks source link

#433 improved fetch results to 10 #436

Closed RLalor closed 1 month ago

RLalor commented 1 month ago

Description

added 1 line of code to increase results to 10 as requested in #433 until one of the other options is implemented.

Checklist

Summary by Sourcery

Increased the maximum number of fetch results to 10 in the YouTube search query.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zen-audio-player-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:37pm
sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request addresses issue #433 by modifying the getSearchResults function in js/zap-common.js to increase the number of fetched results to 10. This change involves adding a single line of code to set the maxResults parameter to 10.


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
RLalor commented 1 month ago

Thanks. This is a nice project to work on. The other changes you mention look quite easy as well. If I get bored I will play with and test those as well and discuss which option is most suited. I tested it and it can fetch 50 results per page. If you try 51 it doesn't produce an error but just ignores it and gets 50. I think you can do 50 per page up to 1000 results / 20 pages. But I also read 500.
Perhaps adding 2 more columns to prevent the page becoming so long is worth considering as well.