zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
19.73k stars 480 forks source link

Back/forward/reload buttons not working while viewing tabs in compact mode #1143

Closed Scepty-SSB closed 2 months ago

Scepty-SSB commented 3 months ago

What happened?

I primarily use compact mode, and I've recently noticed that when I go to use the back/forward/reload page buttons, they won't work if the tab bar is showing. In the attatched video, I try to click the buttons several times and nothing happens.

Edit: Confirmed to still be an issue in 1.0.0-a.39

https://github.com/user-attachments/assets/0c31aa41-e258-4123-9439-ad3416ef6d4f

Reproducible?

Version

1.0.0-a.34

Severity impact

Low

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

mally8 commented 3 months ago

That happens because of the padding the Sidebar uses to align it self. I made a quick and dirty fix if anyone wanna try until the fix is implemented from Zen.

Follow the instructions here Zen Live Editing Docs and then add this to the userChrome.css

I should note. If you are using the Smaller Compact Sidebar, it will move the Sidebar a little down.

@media (-moz-bool-pref: "zen.view.compact") {
  /* the 7px is pretty much a trial and error until it looked nice! */
  #navigator-toolbox {
    --calculation: calc(
      var(--zen-compact-toolbox-margin-single) + 0.15rem +
        var(--zen-element-separation) +
        (7px + (var(--toolbarbutton-inner-padding) * 2))
    );
    --padding-fix: var(--calculation) 0 0 0;
    margin: var(--padding-fix) !important;
    padding: var(--zen-compact-toolbox-margin-single) !important;
    height: calc(100% - var(--calculation)) !important;
  }
}
nazmiyigitefe commented 3 months ago

I experienced it on my Windows device as well. Thanks for the fix.

https://github.com/user-attachments/assets/b5b48889-79b8-447e-b86c-5bdd3d428710

Anthonyy232 commented 3 months ago

+1 for this, really inconvenient since hovering near the back arrow actually opens the side bar too. Honestly it's very difficult to use the browser like this so maybe this would be more like medium severity

BionicBlade0 commented 2 months ago

+1 for this.

mally8 commented 2 months ago

This seems to be fixed in update 1.0.1-a, I personally don't see any issues clicking back/forward anymore!

Scepty-SSB commented 2 months ago

This seems to be fixed in update 1.0.1-a, I personally don't see any issues clicking back/forward anymore!

Agreed.