Closed TomTruyen closed 2 months ago
I seem to be able to build if I replace:
if test "$ZEN_GA_GENERATE_PROFILE"; then
export CXXFLAGS="$CXXFLAGS -fprofile-generate -mllvm -enable-name-compression=false -mllvm -pgo-temporal-instrumentation -fprofile-update=atomic"
mk_add_options "export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0"
ac_add_options --enable-profile-generate=cross
else
ac_add_options --enable-profile-use=cross
ac_add_options --with-pgo-profile-path=$(echo ~)/artifact/merged.profdata
ac_add_options --with-pgo-jarlog=$(echo ~)/artifact/en-US.log
fi
with just
export CXXFLAGS="$CXXFLAGS -fprofile-generate -mllvm -enable-name-compression=false -mllvm -pgo-temporal-instrumentation -fprofile-update=atomic"
mk_add_options "export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0"
ac_add_options --enable-profile-generate=cross
After that I get an error saying that I don't have a locales folder, which I do, but whatever. I commented out: ac_add_options --with-l10n-base="$PWD/browser/locales"
and now it is building, so I guess I will wait and see
Should be fixed now 👍🏽
for the locales, make sure to run sh ./scripts/update-en-US-packs.sh
Not fully resolved. The l110n still gives errors: ERROR: Invalid value --with-l10n-base, /c/Users/Tom/Documents/GitHub/zen-desktop/engine/browser/locales doesn't exist
even after running: download-language-packs.sh
and update-en-US-packs.sh
More info:
I did run all prior steps successfully, I did try to use a surfer bootstrap
afterwards in case it would fix something but with no result.
Full log:
npm run build
> zen-core@1.0.0 build
> surfer build
00:00:00 Applying mozconfig...
00:00:00 Dynamic config 'brand not set, defaulting to 'unofficial'
00:00:00 Dynamic config 'buildMode not set, defaulting to 'dev'
00:00:00 Dynamic config 'buildMode not set, defaulting to 'dev'
00:00:00 Building config based on a dev mode
00:00:00 Config for this `windows` build:
00:00:00 --with-app-name=zen
00:00:00 --with-app-basename=Zen
00:00:00 --enable-official-branding
00:00:00 --with-l10n-base="$PWD/browser/locales"
00:00:00 MOZ_USER_DIR="Zen Browser"
00:00:00 MOZ_APP_BASENAME=Zen
00:00:00 MOZ_APP_PROFILE=zen
00:00:00 MOZ_APP_DISPLAYNAME="Zen Browser"
00:00:00 MOZ_BRANDING_DIRECTORY=branding/unofficial
00:00:00 MOZ_OFFICIAL_BRANDING_DIRECTORY=branding/unofficial
00:00:00 MOZ_DISTRIBUTION_ID=com.zen.browser
00:00:00 MOZ_SOURCE_REPO=https://github.com/zen-browser/desktop
00:00:00 MOZ_SOURCE_CHANGESET=6e5e3c257c8572ccf2184da5f54842f60a85ff5c
00:00:00 MOZ_INCLUDE_SOURCE_INFO=1
00:00:00 --enable-application=browser
00:00:00 --enable-unverified-updates
00:00:00 --enable-raw
00:00:00 --enable-webrtc
00:00:00 --enable-jxl
00:00:00 --enable-av1
00:00:00 --enable-eme=widevine
00:00:00 --allow-addon-sideload
00:00:00 --with-unsigned-addon-scopes=app,system
00:00:00 MOZ_DATA_REPORTING=0
00:00:00 MOZ_SERVICES_HEALTHREPORT=0
00:00:00 MOZ_TELEMETRY_REPORTING=0
00:00:00 MOZ_REQUIRE_SIGNING=
00:00:00 MOZ_REQUIRE_SIGNING=
00:00:00 --target=x86_64-pc-windows-msvc
00:00:00 --disable-maintenance-service
00:00:00 --disable-bits-download
00:00:00 POLLY="-mllvm -polly -mllvm -polly-2nd-level-tiling -mllvm -polly-loopfusion-greedy -mllvm -polly-pattern-matching-based-opts -mllvm -polly-position=before-vectorizer -mllvm -polly-vectorizer=stripmine"
00:00:00 VERBOSE=1
00:00:00 --disable-debug
00:00:00 --with-branding=browser/branding/unofficial
00:00:00 --enable-unverified-updates
00:00:00 --enable-update-channel=unofficial
00:00:00 MOZ_APPUPDATE_HOST=updates.zen-browser.app
00:00:00 Starting build...
00:00:00 Building for "windows"...
WARNING If you get any dependency errors, try running |surfer bootstrap|.
00:00:01 W Clobber not needed.
00:00:02 Using Python 3.11.7 from C:\Users\Tom\.mozbuild\srcdirs\engine-82da6ae43249\_virtualenvs\build\Scripts\python.exe
00:00:02 Adding configure options from C:\Users\Tom\Documents\GitHub\zen-desktop\engine\mozconfig
00:00:02 --with-app-name=zen
00:00:02 --with-app-basename=Zen
00:00:02 --enable-official-branding
00:00:02 --with-l10n-base=/c/Users/Tom/Documents/GitHub/zen-desktop/engine/browser/locales
00:00:02 --enable-application=browser
00:00:02 --enable-unverified-updates
00:00:02 --enable-raw
00:00:02 --enable-webrtc
00:00:02 --enable-jxl
00:00:02 --enable-av1
00:00:02 --enable-eme=widevine
00:00:02 --allow-addon-sideload
00:00:02 --with-unsigned-addon-scopes=app,system
00:00:02 --target=x86_64-pc-windows-msvc
00:00:02 --disable-maintenance-service
00:00:02 --disable-bits-download
00:00:02 --enable-optimize=-O2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -maes -ftree-vectorize -Xclang -w
00:00:02 --enable-wasm-avx
00:00:02 --disable-debug
00:00:02 --with-branding=browser/branding/unofficial
00:00:02 --enable-unverified-updates
00:00:02 --enable-update-channel=unofficial
00:00:02 LDFLAGS=-Wl,-O3 -march=x86-64-v3
00:00:02 POLLY=-mllvm -polly -mllvm -polly-2nd-level-tiling -mllvm -polly-loopfusion-greedy -mllvm -polly-pattern-matching-based-opts -mllvm -polly-position=before-vectorizer -mllvm -polly-vectorizer=stripmine
00:00:02 MOZ_APPUPDATE_HOST=updates.zen-browser.app
00:00:02 MOZ_REQUIRE_SIGNING=
00:00:02 CXXFLAGS=-O2 -flto=thin -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -maes -march=x86-64-v3
00:00:02 MOZ_BRANDING_DIRECTORY=branding/unofficial
00:00:02 MOZ_SOURCE_CHANGESET=6e5e3c257c8572ccf2184da5f54842f60a85ff5c
00:00:02 MOZ_APP_BASENAME=Zen
00:00:02 MOZ_USER_DIR=Zen Browser
00:00:02 RUSTFLAGS=-Clink-args=--icf=safe -C target-feature=+avx -C codegen-units=1 -Ctarget-cpu=x86-64-v3
00:00:02 VERBOSE=1
00:00:02 MOZ_APP_PROFILE=zen
00:00:02 MOZ_INCLUDE_SOURCE_INFO=1
00:00:02 MOZ_APP_DISPLAYNAME=Zen Browser
00:00:02 MOZ_DISTRIBUTION_ID=com.zen.browser
00:00:02 MOZ_SOURCE_REPO=https://github.com/zen-browser/desktop
00:00:02 CPPFLAGS=-O2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -maes -march=x86-64-v3
00:00:02 MOZ_OFFICIAL_BRANDING_DIRECTORY=branding/unofficial
00:00:02 CFLAGS=-O2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -maes -march=x86-64-v3
00:00:02 checking for vcs source checkout... git
00:00:02 checking for a shell... C:/mozilla-build/msys2/usr/bin/sh.exe
00:00:02 checking for host system type... x86_64-pc-windows-msvc
00:00:02 checking for target system type... x86_64-pc-windows-msvc
00:00:02 checking whether cross compiling... no
00:00:02 checking for Python 3... C:/Users/Tom/.mozbuild/srcdirs/engine-82da6ae43249/_virtualenvs/build/Scripts/python.exe (3.11.7)
00:00:02 checking for git... C:/PROGRA~1/Git/cmd/git.exe
00:00:02 checking for Git version... 2.46.0.windows.1
00:00:02 checking for sparse checkout... no
00:00:02 checking for MozillaBuild directory... C:\mozilla-build
00:00:02 checking for MozillaBuild version... 4.1
00:00:02 checking for wget... C:/mozilla-build/msys2/usr/bin/wget.exe
00:00:02 checking for ccache... not found
00:00:02 checking for the target C compiler... C:/Users/Tom/.mozbuild/clang/bin/clang-cl.exe
00:00:02 checking whether the target C compiler can be used... yes
00:00:02 checking the target C compiler version... 18.1.7
00:00:02 checking the target C compiler works... yes
00:00:02 checking for the target C++ compiler... C:/Users/Tom/.mozbuild/clang/bin/clang-cl.exe
00:00:02 checking whether the target C++ compiler can be used... yes
00:00:02 checking the target C++ compiler version... 18.1.7
00:00:02 checking the target C++ compiler works... yes
00:00:02 checking for the host C compiler... C:/Users/Tom/.mozbuild/clang/bin/clang-cl.exe
00:00:02 checking whether the host C compiler can be used... yes
00:00:02 checking the host C compiler version... 18.1.7
00:00:02 checking the host C compiler works... yes
00:00:02 checking for the host C++ compiler... C:/Users/Tom/.mozbuild/clang/bin/clang-cl.exe
00:00:02 checking whether the host C++ compiler can be used... yes
00:00:02 checking the host C++ compiler version... 18.1.7
00:00:02 checking the host C++ compiler works... yes
00:00:02 checking for 64-bit OS... yes
00:00:02 checking for Windows SDK... 0x0a00 in 'C:/Users/Tom/.mozbuild/vs/Windows Kits/10'
00:00:02 checking for Universal CRT SDK... 10.0.22621.0 in 'C:/Users/Tom/.mozbuild/vs/Windows Kits/10'
00:00:03 checking for linker... C:/Users/Tom/.mozbuild/clang/bin/lld-link.exe
00:00:03 checking for host_linker... C:/Users/Tom/.mozbuild/clang/bin/lld-link.exe
00:00:03 checking for the assembler... C:/Users/Tom/.mozbuild/vs/VC/Tools/MSVC/14.39.33519/bin/Hostx64/x64/ml64.exe
00:00:03 checking for llvm-objdump... C:/Users/Tom/.mozbuild/clang/bin/llvm-objdump.exe
00:00:03 checking for rc... C:/Users/Tom/.mozbuild/clang/bin/llvm-rc.exe
00:00:03 checking for ar... C:/Users/Tom/.mozbuild/clang/bin/llvm-lib.exe
00:00:03 checking whether ar supports response files... no
00:00:03 checking for host_ar... C:/Users/Tom/.mozbuild/clang/bin/llvm-lib.exe
00:00:03 checking for -mavxvnni support... yes
00:00:03 checking for -mavx512bw support... yes
00:00:03 checking for -mavx512vnni support... yes
00:00:03 checking for malloc.h... yes
00:00:03 checking for stdint.h... yes
00:00:03 checking for inttypes.h... yes
00:00:03 checking for alloca.h... no
00:00:03 checking for sys/byteorder.h... no
00:00:03 checking for getopt.h... no
00:00:03 checking for unistd.h... no
00:00:03 checking for nl_types.h... no
00:00:03 checking for cpuid.h... yes
00:00:03 checking for fts.h... no
00:00:03 checking for sys/statvfs.h... no
00:00:03 checking for sys/statfs.h... no
00:00:03 checking for sys/vfs.h... no
00:00:03 checking for sys/mount.h... no
00:00:03 checking for sys/quota.h... no
00:00:03 checking for sys/queue.h... no
00:00:03 checking for sys/types.h... yes
00:00:03 checking for netinet/in.h... no
00:00:03 checking for byteswap.h... no
00:00:03 checking for memfd_create in sys/mman.h... no
00:00:03 checking for perf_event_open system call... no
00:00:03 checking whether the C compiler supports -Wbitfield-enum-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wbitfield-enum-conversion... yes
00:00:03 checking whether the C compiler supports -Wformat-type-confusion... yes
00:00:03 checking whether the C++ compiler supports -Wformat-type-confusion... yes
00:00:03 checking whether the C compiler supports -Wshadow-field-in-constructor-modified... yes
00:00:03 checking whether the C++ compiler supports -Wshadow-field-in-constructor-modified... yes
00:00:03 checking whether the C compiler supports -Wtautological-constant-in-range-compare... yes
00:00:03 checking whether the C++ compiler supports -Wtautological-constant-in-range-compare... yes
00:00:03 checking whether the C compiler supports -Wno-error=tautological-type-limit-compare... yes
00:00:03 checking whether the C++ compiler supports -Wno-error=tautological-type-limit-compare... yes
00:00:03 checking whether the C compiler supports -Wunreachable-code-return... yes
00:00:03 checking whether the C++ compiler supports -Wunreachable-code-return... yes
00:00:03 checking whether the C compiler supports -Wunused-but-set-parameter... yes
00:00:03 checking whether the C++ compiler supports -Wunused-but-set-parameter... yes
00:00:03 checking whether the C compiler supports -Wclass-varargs... yes
00:00:03 checking whether the C++ compiler supports -Wclass-varargs... yes
00:00:03 checking whether the C++ compiler supports -Wempty-init-stmt... yes
00:00:03 checking whether the C compiler supports -Wfloat-overflow-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wfloat-overflow-conversion... yes
00:00:03 checking whether the C compiler supports -Wfloat-zero-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wfloat-zero-conversion... yes
00:00:03 checking whether the C compiler supports -Wloop-analysis... yes
00:00:03 checking whether the C++ compiler supports -Wloop-analysis... yes
00:00:03 checking whether the C compiler supports -Wno-range-loop-analysis... yes
00:00:03 checking whether the C++ compiler supports -Wno-range-loop-analysis... yes
00:00:03 checking whether the C++ compiler supports -Wcomma-subscript... no
00:00:03 checking whether the C compiler supports -Wenum-compare-conditional... yes
00:00:03 checking whether the C++ compiler supports -Wenum-compare-conditional... yes
00:00:03 checking whether the C compiler supports -Wenum-float-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wenum-float-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wvolatile... yes
00:00:03 checking whether the C++ compiler supports -Wno-deprecated-anon-enum-enum-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wno-deprecated-enum-enum-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wno-deprecated-this-capture... yes
00:00:03 checking whether the C++ compiler supports -Wcomma... yes
00:00:03 checking whether the C compiler supports -Wduplicated-cond... no
00:00:03 checking whether the C++ compiler supports -Wduplicated-cond... no
00:00:03 checking whether the C++ compiler supports -Wimplicit-fallthrough... yes
00:00:03 checking whether the C compiler supports -Wlogical-op... no
00:00:03 checking whether the C++ compiler supports -Wlogical-op... no
00:00:03 checking whether the C compiler supports -Wstring-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wstring-conversion... yes
00:00:03 checking whether the C++ compiler supports -Wno-inline-new-delete... yes
00:00:03 checking whether the C compiler supports -Wno-error=maybe-uninitialized... no
00:00:03 checking whether the C++ compiler supports -Wno-error=maybe-uninitialized... no
00:00:03 checking whether the C compiler supports -Wno-error=deprecated-declarations... yes
00:00:03 checking whether the C++ compiler supports -Wno-error=deprecated-declarations... yes
00:00:03 checking whether the C compiler supports -Wno-error=array-bounds... yes
00:00:03 checking whether the C++ compiler supports -Wno-error=array-bounds... yes
00:00:03 checking whether the C compiler supports -Wno-error=free-nonheap-object... yes
00:00:03 checking whether the C++ compiler supports -Wno-error=free-nonheap-object... yes
00:00:03 checking whether the C compiler supports -Wno-multistatement-macros... no
00:00:03 checking whether the C++ compiler supports -Wno-multistatement-macros... no
00:00:03 checking whether the C compiler supports -Wno-error=class-memaccess... no
00:00:03 checking whether the C++ compiler supports -Wno-error=class-memaccess... no
00:00:03 checking whether the C compiler supports -Wno-error=atomic-alignment... yes
00:00:03 checking whether the C++ compiler supports -Wno-error=atomic-alignment... yes
00:00:03 checking whether the C compiler supports -Wno-error=deprecated-builtins... yes
00:00:03 checking whether the C++ compiler supports -Wno-error=deprecated-builtins... yes
00:00:03 checking whether the C compiler supports -Wno-unknown-pragmas... yes
00:00:03 checking whether the C++ compiler supports -Wno-unknown-pragmas... yes
00:00:03 checking whether the C compiler supports -Wno-ignored-pragmas... yes
00:00:03 checking whether the C++ compiler supports -Wno-ignored-pragmas... yes
00:00:03 checking whether the C compiler supports -Wno-deprecated-declarations... yes
00:00:03 checking whether the C++ compiler supports -Wno-deprecated-declarations... yes
00:00:03 checking whether the C++ compiler supports -Wno-microsoft-enum-value... yes
00:00:03 checking whether the C++ compiler supports -Wno-microsoft-include... yes
00:00:03 checking whether the C compiler supports -Wno-invalid-noreturn... yes
00:00:03 checking whether the C++ compiler supports -Wno-invalid-noreturn... yes
00:00:03 checking whether the C++ compiler supports -Wno-inconsistent-missing-override... yes
00:00:03 checking whether the C++ compiler supports -Wno-implicit-exception-spec-mismatch... yes
00:00:03 checking whether the C++ compiler supports -Wno-microsoft-exception-spec... yes
00:00:03 checking whether the C++ compiler supports -Wno-unused-local-typedef... yes
00:00:03 checking whether the C++ compiler supports -Wno-ignored-attributes... yes
00:00:03 checking whether the C++ compiler supports -Wno-used-but-marked-unused... yes
00:00:03 checking whether the C compiler supports -Werror=implicit-function-declaration... yes
00:00:03 checking whether the C compiler supports -Wno-psabi... yes
00:00:03 checking whether the C++ compiler supports -Wno-psabi... yes
00:00:03 checking whether the C compiler supports -Wthread-safety... yes
00:00:03 checking whether the C++ compiler supports -Wthread-safety... yes
00:00:03 checking whether the C compiler supports -Wno-error=builtin-macro-redefined... yes
00:00:03 checking whether the C++ compiler supports -Wno-error=builtin-macro-redefined... yes
00:00:03 checking whether the C++ compiler supports -Wno-vla-cxx-extension... yes
00:00:03 checking whether the C compiler supports -Wno-unknown-warning-option... yes
00:00:03 checking whether the C++ compiler supports -Wno-unknown-warning-option... yes
00:00:03 checking whether the C++ compiler supports -fno-sized-deallocation... no
00:00:03 checking whether the C++ compiler supports -fno-aligned-new... no
00:00:04 checking what kind of list files are supported by the linker... list
00:00:04 checking for llvm_profdata... C:/Users/Tom/.mozbuild/clang/bin/llvm-profdata.exe
00:00:04 checking whether llvm-profdata supports 'order' subcommand... yes
00:00:04 checking for rustc... C:/Users/Tom/.cargo/bin/rustc.exe
00:00:04 checking for cargo... C:/Users/Tom/.cargo/bin/cargo.exe
00:00:04 Actually using 'C:\Users\Tom\.rustup\toolchains\stable-x86_64-pc-windows-msvc\bin\rustc.exe'
00:00:04 Actually using 'C:\Users\Tom\.rustup\toolchains\stable-x86_64-pc-windows-msvc\bin\cargo.exe'
00:00:04 checking rustc version... 1.80.1
00:00:04 checking cargo version... 1.80.1
00:00:04 checking for rust host triplet... x86_64-pc-windows-msvc
00:00:05 checking for rust target triplet... x86_64-pc-windows-msvc
00:00:05 checking for rustdoc... C:/Users/Tom/.cargo/bin/rustdoc.exe
00:00:05 checking for cbindgen... C:/Users/Tom/.mozbuild/cbindgen/cbindgen.exe
00:00:05 checking for rustfmt... C:/Users/Tom/.cargo/bin/rustfmt.exe
00:00:05 checking for clang for bindgen... C:/Users/Tom/.mozbuild/clang/bin/clang.exe
00:00:05 checking for libclang for bindgen... C:/Users/Tom/.mozbuild/clang/bin/libclang.dll
00:00:05 checking that libclang is new enough... yes
00:00:05 checking bindgen cflags... -x c++ -fno-sized-deallocation -fno-aligned-new -DTRACING=1 -DIMPL_LIBXUL -DMOZILLA_INTERNAL_API -DRUST_BINDGEN -DWIN32=1 -D_CRT_USE_BUILTIN_OFFSETOF -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=1 -std=gnu++17
00:00:05 checking for tm_zone and tm_gmtoff in struct tm... no
00:00:05 checking for _getc_nolock... yes
00:00:05 checking for localeconv... yes
00:00:05 checking for nodejs... C:\Users\Tom\.mozbuild\node\node.EXE (18.19.0)
00:00:05 ERROR: Invalid value --with-l10n-base, /c/Users/Tom/Documents/GitHub/zen-desktop/engine/browser/locales doesn't exist
00:00:07 C:/Users/Tom/Documents/GitHub/zen-desktop/engine/obj-x86_64-pc-windows-msvc/config.status is out of date with respect to C:/Users/Tom/Documents/GitHub/zen-desktop/engine/browser/config/version.txt
I was having the same issue on Windows with l10n failing because of invalid value.
ERROR: Invalid value --with-l10n-base, /c/Users/Tom/Documents/GitHub/zen-desktop/engine/browser/locales doesn't exist
Seems it's having a trouble with /c/
? so I just went into the config and replaced --with-l10n-base="$PWD/browser/locales"
to --with-l10n-base="C:/../desktop/engine/browser/locales"
and it finally started compiling.
Not sure if it's intended or not but that's the only way it got past the check for me.
This issue should not be closed, it still persists and there is no fix in code, or any mention about this workaround in README
Captchas
What happened?
I am trying to build Zen to contribute to it. On my windows machine after fighting through errors messages I was finally able to run
npm run build
/surfer build
but now I am stuck on an error:Any idea what the cause of this is? I have done all basic steps, surfer bootstrap, imported patches, fetched all dependencies,...
Reproducible?
Version
1.0.0
What platform are you seeing the problem on?
Windows
Relevant log output