zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
15.66k stars 374 forks source link

Unbinding default keybinds does not allow use in extension shortcuts #1334

Open slacksystem opened 1 month ago

slacksystem commented 1 month ago

Captchas

What happened?

After checking the box in keyboard shortcuts to unbind the default keyboard shortcuts, and ensuring ctrl+w is not in my custom keybindings, trying to set one of my extension/add-on shortcuts errors. This seems to apply to all keyboard shortcuts (I have tested with ctrl+f and ctrl+a) but I will use control+w here to demonstrate the behavior.

Steps to reproduce:

  1. Disable all default keybinds and any custom keybind using ctrl+w
  2. Attempt to set an extension shortcut for an addon to ctrl+w Expected behavior: The keybind is set successfully, as any other use of ctrl+w would have been disabled by step 1 above. Actual behavior: A red tooltip is shown saying "Can't override a Zen Browser shortcut".

Again I would like to emphasize this happens for many (likely all) different Zen Browser shortcuts, not just ctrl+w.

It's not possible to reproduce the bug on Firefox as firefox does not have the same (or maybe any) keyboard shortcut menu

Reproducible?

Version

1.0.0-a.35 (64-bit)

What platform are you seeing the problem on?

Linux

Relevant log output

I am unsure where to look for logs, but if someone advises me, I will gladly edit them in here
github-actions[bot] commented 1 week ago

This issue is stale because it has been open for 30 days with no activity.

Please close this issue if you feel it is no longer relevant, or comment if you have more information to share.

slacksystem commented 1 week ago

I see that this has gone stale but it never got a reply from anyone, is this something that can be fixed?