zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
12.94k stars 304 forks source link

Pinned tabs interfere with moving tabs in other workspaces #1559

Open JSGRD22 opened 2 hours ago

JSGRD22 commented 2 hours ago

Captchas

What happened?

Pinning tabs will interfere with the action of moving other unpinned tabs in other workspaces.

Steps to reproduce:

  1. Pin a tab in workspace 1.
  2. Move to workspace 2 and open a series of tabs.
  3. Try moving tabs. Observation: the tab can be moved to anywhere except the topmost position.
  4. Pin 3 more tabs in workspace 1.
  5. Open many tabs in workspace 2.
  6. Try moving the tabs. Observation: no tabs can be moved into the first 4 positions.
  7. Unpin all the tabs in workspace 1.
  8. Try moving the tabs in workspace 2. Observation: everything functions normally now.

General behaviour: Despite being visually moved to the top, the positions of pinned tabs are still "saved" in other workspaces. This is likely due to the "Allow workspaces to have their own pinned tabs" not functioning correctly, resulting in other workspaces thinking they have these tabs pinned without actually being present. This results in normal behaviour when interacting with the tabs in other workspaces, but incorrect behaviour when trying to move the tabs.

My guess is that some variable indicating "number of tabs which are pinned" applies across workspaces. The solution would then be to store the number/position/data of pinned tabs separately across workspaces.

Reproducible?

Version

1.0.1-a.2

What platform are you seeing the problem on?

Windows

Relevant log output

No response

linear[bot] commented 2 hours ago

ZEN-1633 Pinned tabs interfere with moving tabs in other workspaces