search

zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
14.03k stars 338 forks source link

Some Cmd Shortcuts Don't Work Anymore (Cmd+Q Cmd+,) #1629

Open Coops0 opened 1 week ago

Coops0 commented 1 week ago

Captchas

What happened?

On Mac (Sequoia), holding the Cmd key and pressing a number 1-9 usually takes you to that tab index. Now, it just does nothing. I am still able to ctrl+tab through them, and other cmd shortcuts like Cmd+T and Cmd+Cstill work.

Additional broken keybinds: Cmd+F, Cmd+,, Cmd+Q

Reproducible?

Version

1.0.1-a.4

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

linear[bot] commented 1 week ago

ZEN-1669 Cmd+<Number> Doesn't Work Anymore

stavros-k commented 1 week ago

Other broken shortcuts:

Note that the above works if I use the Ctrl instead of Cmd So something is funky there

Coops0 commented 1 week ago

Other broken shortcuts:

* `Cmd`+`Shift`+`T` (Restore tab)

* `Cmd`+`R` (Reload)

* `Cmd`+`Shift`+`L` (Bitwarden autofil trigger)

Note that the above works if I use the Ctrl instead of Cmd So something is funky there

Can confirm all of this - it is very strange ctrl works for these...

stavros-k commented 1 week ago

Can confirm all of this - it is very strange ctrl works for these...

It's just the windows/linux shortcuts, which I assume are the defaults until a mac is identified or something.

netzzwerk commented 1 week ago

Also happening on macOS Sonoma 14.6.1

say4n commented 1 week ago

Possibly caused by: https://github.com/zen-browser/desktop/commit/232fa448ca4177af0cf5d961e385ab2fd40785d1? Seems to pertain to keyboard shortcuts and is tagged as the latest release.

AleksZakirov commented 1 week ago

Other broken shortcuts:

* `Cmd`+`Shift`+`T` (Restore tab)

* `Cmd`+`R` (Reload)

* `Cmd`+`Shift`+`L` (Bitwarden autofil trigger)

* `Cmd` + `A` (Select All)

Note that the above works if I use the Ctrl instead of Cmd So something is funky there

for me Cmd+A, Cmd+T work, Cmd+R and Cmd+Shift+T don't.

sebazelonka commented 1 week ago

Same issue here, I'm on macOS Sequoia 15.0 (24A335)

I started to use Zen today, so IDK if I'm missing some other shortcuts, but at least these ones failed:

mauro-balades commented 1 week ago

Will fix this ASAp, releasing today.

HarryHeres commented 1 week ago

Apologies to everyone. We included a patch for macOS specifically adjusting functionality of the modifiers (supposedly fixing https://github.com/zen-browser/desktop/issues/1363) and it seems like it is interfering with the previous functionality. As @mauro-balades noted, we'll fix this with the new release.

bangoim commented 1 week ago

Other broken shortcuts:

* `Cmd`+`Shift`+`T` (Restore tab)

* `Cmd`+`R` (Reload)

* `Cmd`+`Shift`+`L` (Bitwarden autofil trigger)

* `Cmd` + `A` (Select All)

Note that the above works if I use the Ctrl instead of Cmd So something is funky there

For me, Cmd+R and Cmd+A are working. But would like to add Cmd+L to the list of non-working shortcuts.

Coops0 commented 1 week ago

Unfortunately, after updating, the Cmd+<Number> keybind still doesn't work. Some others do seem to work though. Cmd+, (settings) doesn't seem to work either?

When on the settings tab, other shortcuts do not work now either?? e.x. Cmd+W Ctrl+<number> doesn't work either

EDIT: Cmd+F goes into fullscreen, not search/find

Valadramuz commented 1 week ago

Hi! I don't know if I need to open a new issue but on the latest version 1.0.1-a.4 only the following commands work:

The commands that DO NOT work are:

y2k04 commented 1 week ago

Ctrl+W doesn't work anymore for me. It used to be able to before I restarted the browser. But even after restarting the browser again, CTRL + W works, but only once.

HarryHeres commented 1 week ago

So after the update to 1.0.1-a.4, some of the CMD shortcuts work but some of the still don't, is that right?

josefssonemil commented 1 week ago

So after the update to 1.0.1-a.4, some of the CMD shortcuts work but some of the still don't, is that right?

Correct, 1.0.1-a4 has the behavior that @Valadramuz listed

KarimElsayad247 commented 1 week ago

https://github.com/zen-browser/desktop/issues/1686

On linux:

CTRL + Shift + B (bookmarks bar toggle) does not work as well.

KarimElsayad247 commented 1 week ago

@HarryHeres I'm facing something similar with linux, with ctrl + shift + b not working. Could this be related to this max issue?

bangoim commented 1 week ago

Would like to add that in the in the release notes is said that it was added a new system for handling keyboard shortcuts. The interface is the same, didn't see no difference and it is loaded with duplicates and swapped commands. Also, in MacOS the shortcuts that should be showing Cmd + something are showing as Ctrl + something.

Cmd + F: makes browser go full screen instead of searching inside the tab. Cmd + ,: does not go to settings. Cmd + Shift + B and Cmd + B: not working for bookmarks. Cmd + H: does not open history. Cmd + {number}: does not switch tabs. Cmd + Opt + U: sends to view-source:about:preferences#zenCKS instead of closing split view.

Those are the ones that most impacted me, there is possibly more.

Another thing is the missing labels on some shortcuts and duplicated ones.

image
KarimElsayad247 commented 1 week ago

I can confirm that Alt + 1 through Alt + 9 don't work on linux.

kgarrett67 commented 1 week ago

Not sure if this should go here, but with version 1.0.1-a.4, I cannot open bookmarks or history using Ctrl + B or Ctrl + H.

I am on openSUSE Leap 15.5 and Zen Browser installed via a flatpak.

Update: applied version 1.0.1-a.5 and bookmarks now dock using Ctrl +B.

gk98s commented 1 week ago

I'm on windows and my shortcuts are also all messed up, the open private window changed itself to "ctrl shift p" and the new tab one stopped working as of the latest update.

fhfuih commented 1 week ago

To add: I have created multiple profiles before recent updates, and only the main (default) profile got affected. (macOS 14.7)

EDIT: 5 minutes after I post this, I receive a new update and things work now

KarimElsayad247 commented 1 week ago

How do I update to the recent version? About Zen window doesn't have a way to check for a new version.

Edit: It could be because I installed using Flatpak. I'm now updating using flatpak update

Edit2: Shortcuts are now working for me :+1:

Thanks for the hard work everyone @mauro-balades @HarryHeres You're doing really great work :pray: :pray: :pray:

Amplificator commented 1 week ago

The option for setting a shortcut for "Next tab" and "Previous tab" is gone now - can we have these back?

yoghurtlee-thu commented 4 days ago

Cmd + , broke again in 1.0.1-a-6 :(

Coops0 commented 4 days ago

Cmd + , broke again in 1.0.1-a-6 :(

Unfortunately can confirm, I also notice Cmd + q is broken.

bangoim commented 4 days ago

Cmd + , broke again in 1.0.1-a-6 :(

Cmd + h also not working.

yoghurtlee-thu commented 4 days ago

The problem is still bothering me in 1.0.1-a-7 :(

say4n commented 2 days ago

Seems like 1.0.1-a-5 was the last working version.

sebazelonka commented 2 days ago

same here, I'm on 1.0.1-a.7 and cmd+q cmd+, still broken

bangoim commented 1 day ago

From what I tested in 1.0.1-a.7, those below are broken: