zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
13.97k stars 338 forks source link

Empty "new tab" incorrectly created when closing existing tab #1635

Open neogeographica opened 1 week ago

neogeographica commented 1 week ago

Captchas

What happened?

Only reproducible on Linux apparently:

0) Workspaces feature must be enabled in preferences. 1) Right-click on any link or bookmark and open its page (let's call it foo.com) in a new window. 2) A new window is created with one tab, showing foo.com. 3) In that foo.com tab, middle click on one or more links in the displayed page to open those links as tabs "in the background". 4) Remain on the foo.com tab... don't switch to any of the other tabs yet. 5) In the tab sidebar click the "x" on the foo.com tab to close it. 6) A new empty "New Tab" tab will be created at the bottom of the tab list.

What I would expect is for that new tab to NOT be created.

I hit this with some regularity since this is a not-uncommon browsing pattern for me: open some homepage or other kind of "top-level page" in a new window, while reading it middle-click on various links that I want to check out when I am done with the top-level page, then close the top-level page.

Note: The new tab is not created when I close the foo.com tab, if one of the following is true:

Reproducible?

Version

1.0.1-a

What platform are you seeing the problem on?

Linux

Relevant log output

No response

linear[bot] commented 1 week ago

ZEN-1673 Empty "new tab" incorrectly created when closing existing tab

neogeographica commented 1 week ago

Also FWIW, I have two workspaces configured. I haven't tried replicating this behavior when only having a single workspace.

Not able to replicate this on macOS, only on Linux (Mutter/Gnome in Pop!_OS 22.04).

onthejobtraining commented 1 week ago

Unable to replicate this on Windows version either.

neogeographica commented 1 week ago

Tested it with a single workspace now, same behavior (on Linux).

However, if I completely disable workspaces in the preferences, the bad behavior no longer happens. Updated the initial post above.