Close Split View shortcut is not working on mac

zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!

https://zen-browser.app

Mozilla Public License 2.0

18.46k stars 451 forks source link

Close Split View shortcut is not working on mac #1738

Open samhuss opened 1 month ago

samhuss commented 1 month ago

Captchas

[X] I have read the instructions.
[x] I have searched existing issues and avoided creating duplicates.
[ ] I am not filing an enhancement request.

What happened?

Split view shortcuts work perfectly for all directions (H,V,G), but the shortcut for splitting the view doesn't work: Ctrl+Opti+U

I'm using sidebery extension to manage all the tabs so I'm totally depending on the shortcuts to open and close the split views.

I Tried to change the key bindings and add new one from "settings -> Keyboard shortcuts" but the new shortcut was never saved. I know that there are some issues with key bindings on mac but this one is different than the Cmd and Ctrl issue.

Reproducible?

[ ] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.5 (64-bit)

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

linear[bot] commented 1 month ago

ZEN-1758 Close Split View shortcut is not working on mac

samhuss commented 1 month ago

---- temporary fix One solution that let the default shortcuts work was to add a new keyboard of type "Unicode Hex Input" that disables the the special characters with Alt key, doing so let the shortcut "Ctrl+Option+U" works

However, I can't stick to this keyboard layout as it disabled the cursor movement with the Alt key and Arrow right and left "Alt+Left Arrow".

What I see as a quick fix is to fix the problem of saving the keyboard shortcuts, whenever I change those key bindings to anything else then restart I find the default key bindings back again.

XavierEduardo99 commented 1 month ago

It isn't working on Microsoft Windows 11 also. I'm not sure if this is any help, but my keyboard layout is: US-International

Edit: Just discovered that even though I change the keyboard shortcut, whenever I close and re-open the browser, the default Ctrl+Alt+U is set

stoicAlchemist commented 2 days ago

This is still happening after some updates. I would suggest adding a contextual menu item to close the split as a workaround and maybe even keep it for mouse users, right now I don't have a way to close splits without closing the involved tabs.

esrid commented 1 day ago

here for the same issues @stoicAlchemist just posted above. somehow instead of closing the split it open the source code of the current page.