Workspace default container setting being overridden/ignored by sync

sjclayton commented 1 month ago

Captchas

[X] I have read the instructions.
[X] I have searched existing issues and avoided creating duplicates.
[X] I am not filing an enhancement request.

What happened?

Ok, here is the scenario... I have 2 machines I use regularly, one Linux (primary) and one Windows (work).

I have 4 workspaces set up (eg, Workspace A,B,C,D) on both, they are synced with the workspace sync option. I also have 4 containers set up (eg, Container A,B,C,D), they are identical on both machines, names/colors and icons.

I set Workspace C's default container to Container D on my Linux machine, it removes the default container set on my Windows laptop for Workspace C (also set to Container D), if I then manually set Container D as the default container for Workspace C on this Windows machine, then it clears it from being set on my Linux machine.

So basically which ever machine I set it on clears the setting on the other.

Expected Result:

Both machines have the same named workspace with the same default container set.

Reproducible?

[ ] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.10

What platform are you seeing the problem on?

Linux, Windows

Relevant log output

No response

linear[bot] commented 1 month ago

ZEN-2022 Workspace default container setting being overridden by sync

niklaswimmer commented 1 month ago

Hey, wild guess of mine, but do you sync (as in Firefox's sync feature) your containers or have you just created containers with the same name on both machines? If so, I would suspect (no clue how it really works -> a wild guess) that Zen stores the container ID, which differs between the machines and that it clears the container field if it can not one with the same ID locally.

sjclayton commented 1 month ago

@niklaswimmer

This is supposed to be fixed by the pull request mentioned above, so the behaviour is clearly something that was not implemented in the first place, which is why it wasn't working.

niklaswimmer commented 1 month ago

Ups, I don't know how I missed that linked PR.

However, maybe I misunderstand something, but if by Containers we mean the Multi-Account Container extension, then syncing them is already possible and can be enabled in the extension's settings (although I gotta admit the only reason why I am in this thread is because that was not working particularly well... so I am excited to see another solution being developed).

dosubot[bot] commented 3 days ago

Hi, @sjclayton. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

Problem with workspace synchronization between Linux and Windows machines.
Setting a default container on one machine clears it on the other.
Speculation that different container IDs on each machine might be the cause.
A pull request was mentioned as a potential fix, but the issue persists.
Multi-Account Container extension was suggested but hasn't worked well.

Next Steps:

Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here.
If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

zen-browser / desktop