search

zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
16.32k stars 385 forks source link

Refactor sidebar expanded on-hover functionality and fix sidebar expa… #2288

Closed Richard-Woessner closed 5 days ago

Richard-Woessner commented 6 days ago

…nd/collapse behavior

ISSUE: #2156

Summary by CodeRabbit

coderabbitai[bot] commented 6 days ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces modifications to the `ZenUIManager.mjs` and `zen-settings.js` files, focusing on managing sidebar expansion and hover detection in the Zen Marketplace. Key updates include the addition of a new property to track hover state, changes in variable declarations from `let` to `const`, and refinements to event handling and theme management. These changes aim to improve the functionality and user experience related to sidebar behavior and theme preferences. ## Changes | File Path | Change Summary | |------------------------------------------------|-----------------------------------------------------------------------------------------------------------| | `src/browser/base/content/ZenUIManager.mjs` | - Added `_hoverPausedForExpand` property to `gZenUIManager`.
- Updated `openAndChangeToTab`, `init`, `_updateOnHoverVerticalTabs`, and `toggleExpand` methods to use `const` instead of `let`.
- Enhanced logic for managing sidebar expansion and hover detection. | | `src/browser/components/preferences/zen-settings.js` | - Updated `_initializeTabbarExpandForm` to set default sidebar state based on new hover preference.
- Improved event listeners and keyboard shortcut management. | ## Possibly related PRs - **#2251**: The changes in `zen-settings.js` related to managing preferences and event handling are relevant as they involve the same file and enhance user experience, similar to the modifications made in the main PR regarding sidebar expansion and hover detection. ## Suggested reviewers - mauro-balades
📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: ASSERTIVE**
📥 Commits Files that changed from the base of the PR and between 2214ab3a17b60bc835674413f8e34c7420f17f21 and 94b32c38e485789596c20c7b519008e74939aebb.
📒 Files selected for processing (1) * src/browser/components/preferences/zen-settings.js (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
src/browser/components/preferences/zen-settings.js (1)
`624-624`: **Setting defaultExpandPref is correct, but pausedForExpandPref needs handling.** The logic to set `defaultExpandPref` to false when hover mode is enabled is correct. However, as noted in a previous review, the new `pausedForExpandPref` should also be reset when changing the expand strategy.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Richard-Woessner commented 6 days ago

https://github.com/user-attachments/assets/b3d1fbf0-3652-44ba-90a4-67bae3a3bc25

Anthonyy232 commented 6 days ago

Any chance of an animation when it is sliding back in? I remember a PR for that a while back but seems like it got closed..

Richard-Woessner commented 5 days ago

Ya I messed up this pr so it closed so it hasn't been merged yet

mauro-balades commented 5 days ago

Thanks a lot!