zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
19.62k stars 480 forks source link

appimage.sh is not setting correct permissions on updated .AppImage file #2313

Closed rholak closed 9 hours ago

rholak commented 1 month ago

Captchas

What happened?

When using the appimage.sh script to get updates, the new ZenBrowser.AppImage file does not have the executable permission set. The initial install does setthe permission correctly. It is the update process that seems to have the issue.

Reproducible?

Version

1.0.x

What platform are you seeing the problem on?

Linux

Relevant log output

❯ bash <(curl https://updates.zen-browser.app/appimage.sh)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12497  100 12497    0     0   155k      0 --:--:-- --:--:-- --:--:--  156k
[i] ╔════════════════════════════════════════════════════╗
[i] ║                                                    ║
[i] ║    (ノ◕ヮ◕)ノ*:・゚✧  Zen Browser Installer            ║
[i] ║                                                    ║
[i] ║    CPU: AVX2 Supported (Optimized Version)         ║
[i] ║    Status: Zen Browser Not Installed               ║
[i] ║    zsync: Installed (Needed for Updates)           ║
[i] ║                                                    ║
[i] ╚════════════════════════════════════════════════════╝
[i]
[i] (★^O^★) What would you like to do?
[i]   1) Install
[i]   2) Uninstall
[i]   3) Check for Updates
[i]   0) Exit
Enter your choice (0-3): 1
[i]
[w] Auto dedecting AVX2 support...
[w] Downloading Zen from https://github.com/zen-browser/desktop/releases/latest/download/zen-specific.AppImage
[i]
[i] Installing Zen Browser...
################################################################################################################################################################################################################################################## 100.0%
[i] Install completed successfully!
[i]
[i] (。♥‿♥。) Zen Browser installed successfully!
[i]
[i] Thank you for using Zen Browser Installer!

❯ ls -l ~/.local/share/AppImage/ZenBrowser*
.rwxrwxr-x 98M rholak rholak 24 Oct 15:38  /home/rholak/.local/share/AppImage/ZenBrowser.AppImage*

❯ bash <(curl https://updates.zen-browser.app/appimage.sh)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12497  100 12497    0     0   153k      0 --:--:-- --:--:-- --:--:--  154k
[i] ╔════════════════════════════════════════════════════╗
[i] ║                                                    ║
[i] ║    (ノ◕ヮ◕)ノ*:・゚✧  Zen Browser Installer            ║
[i] ║                                                    ║
[i] ║    CPU: AVX2 Supported (Optimized Version)         ║
[i] ║    Status: Zen Browser Installed                   ║
[i] ║    zsync: Installed (Needed for Updates)           ║
[i] ║                                                    ║
[i] ╚════════════════════════════════════════════════════╝
[i]
[i] (★^O^★) What would you like to do?
[i]   1) Install
[i]   2) Uninstall
[i]   3) Check for Updates
[i]   0) Exit
Enter your choice (0-3): 3
[i]
[w] Auto dedecting AVX2 support...
[i] Checking for updates...
[i] Checking for Update...
################################################################################################################################################################################################################################################## 100.0%
[i] Checking for Update successfully!
[i] (。♥‿♥。) Congrats! Zen Browser is up-to-date!
[i]
[i] Thank you for using Zen Browser Installer!

❯ ls -l ~/.local/share/AppImage/ZenBrowser*
.rw------- 98M rholak rholak 19 Oct 21:31  /home/rholak/.local/share/AppImage/ZenBrowser.AppImage
.rwxrwxr-x 98M rholak rholak 24 Oct 15:38  /home/rholak/.local/share/AppImage/ZenBrowser.AppImage.zs-old*
dosubot[bot] commented 1 week ago

Hi, @rholak. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

Next Steps:

Thank you for your understanding and contribution!