Zen browser cant restore tabs in their specific workspaces after closing the browser (Added video proof)

shwetarkadam commented 1 month ago

Captchas

[X] I have read the instructions.
[X] I have searched existing issues and avoided creating duplicates.
[X] I am not filing an enhancement request.

What happened?

After updating Zen Browser to 1.0.1-a.16 to fix side toggle commands, it now fails to restore tabs in their workspaces after closing.

Video of the issue https://github.com/user-attachments/assets/df989ec0-9bd5-493a-8b15-a2e210a203a4

https://github.com/user-attachments/assets/c7082b14-1ca8-4752-b5c2-b95d67644289

Reproducible?

[X] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.16

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

Notes

I checked in the settings for anything related to session management or startup or restore keyword couldn’t find anything

dosubot[bot] commented 1 month ago

Hey @shwetarkadam! 👋 I'm here to help you with any bugs, questions, or contributions you have. Let's squash those bugs together!

I found some relevant information regarding the issue of tabs not restoring in their specific workspaces after closing the browser. In version 1.0.1-a.16, changes were made that could affect tab restoration in workspaces. These changes involve setting attributes like zen-workspace-id and zenDefaultUserContextId on tabs during restoration, which are crucial for maintaining the correct state of tabs across sessions ^[1].

Additionally, there are recent patches related to workspace management that might address the issue of tabs not restoring correctly. These patches include handling tab attributes related to "zenWorkspace" and "zenDefaultUserContextId" during tab restoration, which could potentially resolve the issue ^[1].

If the problem persists, it might be helpful to check if these attributes are being correctly set and restored in your current setup.

To continue talking to Dosu, mention @dosu.

salamijason commented 3 weeks ago

Hi this is really weird. Could you try a new profile? There's a good chance the profile got corrupted during the update. Please also make sure you have this ticked:

jalzur commented 1 week ago

Not sure if this could help, but I've noticed that the problem is when you close the window, not the app, in macOS. It also happens with other programs such as VSCode or Sublime Text.

If you close the app (right click in the dock icon and select close) and reopen it, it should restore the tabs. But if you close the window (the close red button) then the app is still open in the dock but without any window, and if you try to open a new window now, it won't restore the tabs.

It would be nice an option such as "close the app instead of closing the last window".

salamijason commented 6 hours ago

@jalzur

It would be nice an option such as "close the app instead of closing the last window".

This option exists! If you click the three dot menu, there is an option to close Zen right at the bottom.

Due to session store, if you close windows one at a time, there's a good chance only the tabs of the very last window will be restored on next launch. To avoid this, it's best to use the option I mentioned earlier.

The original poster hasn't responded in quite a bit so I'll be closing this for now. Please reopen if the issue persists.

zen-browser / desktop