zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
16.62k stars 394 forks source link

Bookmarks toolbar items in the tab bar are broken after collapsing tab bar #2547

Open VuthMuul opened 2 hours ago

VuthMuul commented 2 hours ago

Captchas

What happened?

An update to Zen made the bookmarks toolbar show a > when there's not enough room for bookmarks - which works great when collapsed - but has added a bug where expanding again the bar is empty until resize, however the arrow remains (not clickable and nothing in there anyway) along with extra space and the whole tab bar is wider. This persists until the browser is restarted

Working as normal image Collapsed, reduces to overflow image Expanded, bookmarks are missing image After resize they return but overflow remains and the bar is permanently wider too image What my browser customisation looks like. Mods are disabled. image

I find having the bookmarks toolbar nestled in the tab bar a great way to add a few bookmarks without taking up much space or requiring access to the menu. The overflow change is great (previously the bar just got cropped) but has some issues.

Reproducible?

Version

1.0.1-a.17

What platform are you seeing the problem on?

Windows

Relevant log output

No response

dosubot[bot] commented 2 hours ago

Hello @VuthMuul! I'm here to help you with any bugs, questions, or contributions. Let's tackle this issue together!

There is a known issue related to the bookmarks toolbar where it extends beyond the screen area, which might be similar to what you're experiencing. This issue was discussed in this closed issue and referenced by several other issues, including one where the browser window becomes too wide to use and another where the bookmarks toolbar overflows the top panel. A suggested workaround is to extend the window onto a second monitor to make it wide enough to encompass the entire bookmarks bar, which might help normalize the display and allow you to resize the tab bar afterward [1].

Additionally, a recent update to Zen introduced a function that affects the bookmarks toolbar by setting the favicon and preview image for the bookmark panel, which might be related to the changes you're observing [2].

For the specific issue of the bookmarks disappearing and the overflow indicator remaining after expanding the tab bar, it might be related to the ResizeObserver used in the _zenInitBrowserLayout function, which handles resizing events for the tab bar [3].

If these suggestions don't resolve the issue, it might require further investigation or a fix in a future update.

To continue talking to Dosu, mention @dosu.

Richard-Woessner commented 2 hours ago

Confirmed on nightly 1.0.1-t.17