zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
17.13k stars 402 forks source link

Left Active Window borders in Split Vew doesn't render correctly. #2647

Open Spacellary opened 4 hours ago

Spacellary commented 4 hours ago

Captchas

What happened?

Active Window borders on the left side in Split Vew won't render correctly. the side bar overlaps over it as can been seen in screenshot number 2.

  1. Right window active:
    zen_9fQJocJpNa

  2. Left window active:
    zen_V2hCoOHwcZ

Reproducible?

Version

133.0b4 (64-bit)

What platform are you seeing the problem on?

Windows

Relevant log output

No response

dosubot[bot] commented 4 hours ago

Hey @Spacellary! I'm here to help you with any bugs, questions, or contributions. Let's tackle this issue together!

The issue with the left active window borders not rendering correctly in Split View mode, where the sidebar overlaps the border, might be related to recent changes in the sidebar rendering. The patch modifies the setPosition method in browser-sidebar.js, which adjusts the order and positioning of elements within the sidebar. These changes could potentially impact the rendering of window borders if they rely on the positioning and styling of these elements [1].

Additionally, the ZenViewSplitter class handles the layout of elements in Split View mode, and any misconfiguration in the applyGridLayout method could also contribute to this issue [2].

To address this, you might want to review the CSS rules and JavaScript logic related to the sidebar and active window borders to ensure they are correctly applied and do not interfere with each other.

To continue talking to Dosu, mention @dosu.

Axenide commented 3 hours ago

This is actually happening only when the Tab Sidebar is expanded, both with split and normal views.

https://github.com/user-attachments/assets/8d1d1878-c599-4bc4-a357-9e57724dab81