zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
18.64k stars 452 forks source link

Zen-components submodule can't be found #2648

Open thatcomputerguy0101 opened 2 weeks ago

thatcomputerguy0101 commented 2 weeks ago

Captchas

What happened?

When trying to initialize the submodules to locally build a release tag, it errors out due to the recent monorepo refactor in ec65a69. While that refactor is okay for newer versions, deleting/privating the zen-components repository breaks trying to do builds of historical versions. It would probably be best to restore that repository and mark it as a read-only archive, if not indefinitely at least until the monorepo refactor is well into the past.

Reproducible?

Version

1.0.1-a.17

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

$ git submodule update --init --recursive --depth 1
Cloning into '.../desktop/src/browser/base/content/zen-components'...
remote: Repository not found.
fatal: repository 'https://github.com/zen-browser/components/' not found
fatal: clone of 'https://github.com/zen-browser/components' into submodule path '.../desktop/src/browser/base/content/zen-components' failed
Failed to clone 'src/browser/base/content/zen-components'. Retry scheduled
Cloning into '.../desktop/src/browser/base/content/zen-components'...
remote: Repository not found.
fatal: repository 'https://github.com/zen-browser/components/' not found
fatal: clone of 'https://github.com/zen-browser/components' into submodule path '.../desktop/src/browser/base/content/zen-components' failed
Failed to clone 'src/browser/base/content/zen-components' a second time, aborting
dosubot[bot] commented 2 weeks ago

Hello @thatcomputerguy0101! I'm here to help you solve bugs, answer questions, and become a contributor. Let's tackle this issue together while we wait for a human maintainer.

I found a similar closed issue that might be relevant to your problem: Zen-Components just went private. The issue was resolved by moving the components into the main repository, as seen in commit ec65a69 [1].

The current location of the zen-components within the monorepo after the refactor is content/browser/zen-components/ [2]. This means that the submodule is no longer needed, and you should be able to build the project without it by using the updated structure in the monorepo.

To continue talking to Dosu, mention @dosu.

thatcomputerguy0101 commented 2 weeks ago

@dosu That issue is related, but does not resolve building older releases of Zen.

dosubot[bot] commented 2 weeks ago

Building older releases of Zen that relied on the zen-components submodule can be challenging due to the monorepo refactor. Unfortunately, there isn't specific documentation or a migration guide available for building older releases after the refactor [1]. One potential approach is to manually recreate the zen-components submodule by locating an archived branch or tag that still contains it, though I couldn't find specific information on such branches or tags [1]. Alternatively, you might consider checking for any forks or alternative repositories that might still have the zen-components submodule [1].

To continue talking to Dosu, mention @dosu.