zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
17.34k stars 406 forks source link

Drag and drop for sidebar widening and shrinking is offset seems like can't widen sidebar. #2659

Open mikedlr opened 1 day ago

mikedlr commented 1 day ago

Captchas

What happened?

When I drag the width of the sidebar it doesn't start moving until I am quite a number of pixels to the right of the bar. This is slightly inconvenient, but also, before you realize what's happening it seems like drag doesn't work at all.

Reproducible?

Version

1.0.1-a.17 (Firefox 132.0) (64-bit)

What platform are you seeing the problem on?

Linux

Relevant log output

No response

mikedlr commented 1 day ago

Video of issue:

Screencast from 2024-11-05 10-29-35.webm

This is on a fresh profile where the only thing I have done is open some tabs and pin them.

(I can't get the pointer to capture in the video - in this, imagine a pointer that starts off at the edge of the sidebar, where it is clicked, moves to the level of the settings icons and only then does the sidebar start expanding)

dosubot[bot] commented 1 day ago

Hey @mikedlr! I'm Dosu, a bot here to help you with bugs, questions, and contributions. Let's take a look at the issue together.

I couldn't find any specific known issues or comments in the codebase related to the sidebar resizing offset problem. However, there is an event listener for the sidebar's drag-and-drop resizing functionality. The handleSplitterMouseDown function handles the mouse down event on the sidebar splitter, initiating the resizing process. It adds a mousemove event listener to handle resizing as the mouse moves and a mouseup event listener to stop resizing when the mouse button is released [1].

Additionally, the CSS styles applied to the sidebar and its drag handle might affect the offset during resizing. For example, the transition on the width (transition: width 0.3s ease-in-out;) and the width constraints (min-width, max-width) could influence the resizing behavior [2].

If the issue persists, you might want to check if there are any platform-specific considerations for Linux that could affect the sidebar's resizing behavior, although I couldn't find any specific information on that.

To continue talking to Dosu, mention @dosu.

mikedlr commented 1 day ago

Okay, I lied. I had immediately experimented with setting

layout.css.devPixelsPerPx = 1.5

and this only triggers after doing that. That means it's likely a bug but likely a very obscure one.