zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
18.68k stars 454 forks source link

Bookmarks and tabs in compact mode #2732

Open usmanibrahim74 opened 1 week ago

usmanibrahim74 commented 1 week ago

Captchas

What happened?

I'm using tabs on the right side with compact view. when I toggle the compact mode with keyboard shortcut. there is just empty space on right side with no tabs in it. hovering over it fixes it.

a similar glitch appear when I press Ctrl+B in compact view. bookmarks open but the tabs space also popup without the tabs. hovering over it fixes it. it is happening in both collapsed tab area and expanded tab area. see the screenshots.

this issue also happen when I enable or disable Zen Mods.

also there is another bug in customize toolbar settings. the done button is not readable. also can we have shortcut to expand and collapse tabs instead of just a button in top bar

Simple Compact View Toggle image

Opening Bookmarks image image

Disable/Enable Zen Mods image

Customize Toolbar image

Reproducible?

Version

1.0.1-a.17 (Firefox 132.0) (64-bit)

What platform are you seeing the problem on?

Linux

Relevant log output

No response

dosubot[bot] commented 1 week ago

Hey there, @usmanibrahim74! 👋 I'm here to help you with bugs, questions, and becoming a contributor. I'll assist you while we wait for a human maintainer.

I found some similar issues that might be related to the problems you're experiencing:

  1. Tabs Do Not Expand On Hover After Toggling Compact Mode: This issue is related to the behavior of tabs not expanding on hover after toggling compact mode. The problem arises because the toggleExpand function sets the preference zen.view.sidebar-expanded.on-hover to false, which disables hover detection. This setting is not automatically reverted when compact mode is toggled off [1].

  2. Sidebar Hover and Right Click Makes the Sidebar Disappear: This issue involves the sidebar disappearing due to hover detection logic. A suggested solution is to modify the hover detection logic to be less sensitive or require a more deliberate action to hide the sidebar [2].

Regarding the Ctrl+B shortcut, I couldn't find specific information on its implementation in the codebase. However, it seems to be causing a similar issue with the tab space popping up without tabs, which might be related to the hover detection logic mentioned above.

For the empty space issue when enabling or disabling Zen Mods, I couldn't find specific details, but it might be related to the same hover detection or preference settings.

As for the shortcut to expand and collapse tabs, the toggleExpand function in the gZenVerticalTabsManager handles this, and it can be linked to a keyboard shortcut. In the current setup, the Alt+B shortcut is used for this purpose [3].

Lastly, the issue with the "Done" button in the Customize Toolbar settings wasn't specifically addressed in the available information, so further investigation might be needed for that part.

To continue talking to Dosu, mention @dosu.

usmanibrahim74 commented 1 week ago

@dosu thanks for explaining things. I tried to search the issues but couldn't find it. I guess it already been identified, now with some extra use cases. thanks for shortcut.

The Done button in Customize Toolbar is easy to be found if someone open it. I tried it with disabling Zen Mods to avoid any issue because of any theme I installed. but it was still there.

dosubot[bot] commented 1 week ago

You're welcome! It seems like you've done a thorough job of identifying and testing the issues. If the "Done" button problem persists even with Zen Mods disabled, it might be worth reporting it as a separate issue if it hasn't been logged yet. This way, the maintainers can address it specifically. If you have any more questions or need further assistance, feel free to ask!

To continue talking to Dosu, mention @dosu.