zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
18.62k stars 452 forks source link

Keyboard shortcut binding issue on macOS #2735

Open lemon-sundae opened 1 week ago

lemon-sundae commented 1 week ago

Captchas

What happened?

On macOS, you can input some special symbols by holding the ⌥(option) key. Normally this is only when you are typing and does not prevent you from using keyboard shortcuts, you can ⌥A ⌥B or whatever you like. However currently zen is doing incorrectly. For example, if you are trying to bind a function to ⌥T, it will appear like this

image

I tested several keys. Most of the time they actually work, just look weird. But in some cases there would be unexpected behaviors.

Reproducible?

Version

1.0.1-a.17

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

dosubot[bot] commented 1 week ago

The issue you're experiencing with keyboard shortcuts on macOS, particularly involving the ⌥ (option) key, seems to be related to how the application processes and displays these shortcuts. The current implementation might not be correctly handling the visual representation of shortcuts involving the ⌥ key, which can lead to unexpected behaviors or incorrect displays.

To address this, you might want to check the KeyShortcutModifiers class and related methods that handle modifier keys and their string representations. This class is responsible for managing how modifier keys are interpreted and displayed, and it includes specific logic for macOS [1]. Adjustments in this area could potentially resolve the display issues you're encountering.

Additionally, ensure that the _initializeCKS function and related UI components are correctly parsing and displaying the shortcuts, as this function is responsible for setting up the UI for keyboard shortcuts [2][3].

To continue talking to Dosu, mention @dosu.

powext commented 1 week ago

I can confirm that on macOS shortcuts are totally broken, i can't even open a tab (1.0.1-a.17)

lemon-sundae commented 1 week ago

I can confirm that on macOS shortcuts are totally broken, i can't even open a tab (1.0.1-a.17)

Well, I didn't encounter this problem, shortcuts work normally, including ⌘T for new tab

powext commented 1 week ago

FYI i have a new installation and default bindings since it's my first day with Zen