zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
17.94k stars 436 forks source link

New Tab button missing from toolbar/customisation #2793

Open VuthMuul opened 2 days ago

VuthMuul commented 2 days ago

Captchas

What happened?

a18 removed the New Tab button from customisation. This means if you disable the "new tab in tab list" there is now no New Tab button at all.

Removing the button from the default layout in favour of the embedded one is fine, but it needs to remain available in the customisation selection.

image

Reproducible?

Version

1.0.1-a.18

What platform are you seeing the problem on?

Windows

Relevant log output

No response

dosubot[bot] commented 2 days ago

There are a few relevant details regarding the New Tab button issue in version 1.0.1-a.18. The changes in this version include the addition of the _hideToolbarButtons method, which explicitly hides the 'new-tab-button' by setting its hidden attribute to true. Additionally, CSS changes in zen-tabs/vertical-tabs.css set #newtab-button-container and #tabs-newtab-button to display: none !important;, contributing to the button's unavailability in the customization options. Furthermore, the new-tab-button was commented out in the defaultPlacements and verticalTabsDefaultPlacements arrays, preventing it from appearing in the customization options [1][2][3].

There are also configuration settings that control the visibility of the New Tab button, such as the preference zen.tabs.show-newtab-vertical, which, when enabled, sets #tabs-newtab-button to display: flex !important; [4][1][2].

For similar issues, you might find the closed issue New Tab button missing in 1.0.1-a.3 relevant, which discusses the New Tab button not showing when at the bottom of the tab bar [5].

To continue talking to Dosu, mention @dosu.

wysh3 commented 2 days ago

yeah i would love the have a moveable new tab button back

kar731 commented 2 days ago

Duplicate of #2778