search

zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
17.95k stars 437 forks source link

Zen sidebars bug #2818

Open claymorwan opened 2 days ago

claymorwan commented 2 days ago

Captchas

What happened?

After the new 1.0.1-a.18 update, I've found 3 bugs with the sidebar:

  1. The toolbar doesn't go away when opening the sidebar. image
  2. The sidebar's button look odd. image
  3. The button to open the sidebar can't be moved or removed from the toolbar anymore, maybe it's a feature but I find it a bit annoying since it's more of a movable button.

Reproducible?

Version

1.0.1-a.18

What platform are you seeing the problem on?

Linux

Relevant log output

No response

dosubot[bot] commented 2 days ago

Hey @claymorwan! I'm here to help you with any bugs, questions, or contributions. Let's tackle this together!

I found a similar closed issue that might be related to the sidebar button's appearance: Sidebar buttons pushed to left when collapsed. The solution suggested there was to add an align-items: center to correct the alignment issue [1].

Regarding the 1.0.1-a.18 update, several changes could affect the sidebar functionality:

  1. Hover Detection and Sidebar Expansion: The sidebar's state is managed based on hover detection and expansion preferences. If the sidebar is expanded, hover detection is disabled [2].

  2. Toggle Sidebar Expansion: The method for toggling the sidebar's expanded state and hover detection has been updated [2].

  3. Sidebar Positioning: The order of elements within the sidebar is adjusted dynamically, which could affect the layout and interaction [2].

For the issue with the toolbar not going away, it might be related to CSS properties applied to the sidebar and toolbar elements. Fixed height constraints and padding/margin adjustments could cause layout issues [3].

The inability to move or remove the sidebar button might be due to changes in how the sidebar button's position and behavior are managed. The ZenSidebarManager module handles the sidebar's open/close behavior, and changes in this module might have affected the button's movability [4].

To continue talking to Dosu, mention @dosu.