zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
18.52k stars 452 forks source link

Enabled new tab settings controls are invisible until you mouse over them #3037

Open Smooth-E opened 2 days ago

Smooth-E commented 2 days ago

Captchas

What happened?

Today I noticed the new "Weather" option was added to the new tab page and I wanted to disable it. Upon opening the options side pane I saw that this option has no switch, but when I moused over it, the switch appeared. Though, removing the mouse from this option's box makes the switch disappear again. When the option is turned off, the switch stays visible at all times. Later I discovered that this applies to all options in this pane.

Mouse over webpage
Option enabled
Mouse over the option box
Option enabled
Mouse over webpage
Option disabled
Switch is invisible Enabled switch is visible when moused over Disabled switch is visible at all times

Reproducible?

Version

1.0.1-a.19 (Firefox 132.0.1)

What platform are you seeing the problem on?

Windows

Relevant log output

No response

rdbo commented 1 day ago

On a side note, shouldn't the weather thing be disabled by default as well? I just started testing the browser and found that odd

Smooth-E commented 15 hours ago

On a side note, shouldn't the weather thing be disabled by default as well? I just started testing the browser and found that odd

I don't think so. When you bring a new feature into your project you either enable it by default if its a quality of life feature, or make an introduction pop-up of some sort, if it is a more focused change, to make those who may need such focused feature aware of it. The weather widget is easy to disable and most people will appreciate additional info on their new tab page, in my opinion

rdbo commented 14 hours ago

The weather widget is easy to disable

True, I just brought it up because since privacy seems to be a big thing here, would be weird to ping a third party service by default and show your city location Also it seems that this weather thing is actually done by Firefox and not Zen (correct me if I'm wrong), so maybe they will consider disabling it in the future