zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
17.15k stars 403 forks source link

Context menu in dark mode does not work well #467

Open henoktx opened 2 months ago

henoktx commented 2 months ago

What happened?

When using dark mode in Zen, the texts in the context menu also become dark, lacking contrast. In light mode, everything is normal.

Captura de tela de 2024-08-22 23-41-47

I uninstalled and reinstalled several times, erasing all data and settings, but it didn't work. I installed the package from the flatpak store.

Reproducible?

Version

1.0.0-a.15

Severity impact

High

What platform are you seeing the problem on?

Linux

Relevant log output

No response

mauro-balades commented 2 months ago

Do you have any themes installed?

Yasir-Zafar commented 2 months ago

I am also having this issue i am on arch linux + wayland /Hyprland and am using the catppuccin theme on gtk i could not reproduce this on mozilla firefox or on the floorp browser is there a about:config setting i could toggle atm to prevent using the gkt theme?

Yasir-Zafar commented 2 months ago

[Update] @henoktx I fixed this by deleting the flatpak and switching over to to the binary version of zen 1.0.0.a.28-1 from the Arch AUR. Maybe use the binary in the realeases tab? Potential bug with flatpak?

henoktx commented 2 months ago

@Yasir-Zafar Maybe. I installed it with AppImage files, and it worked without the bug.

pokhrelashok commented 2 months ago

I am facing a similar issue (installed from flatpak) image

eifr commented 1 month ago

same. installed with flatpak. (1.0.0-a.37 (64-bit)) image

navoyan commented 1 month ago

This problem occurs because of the installed GTK theme. If you installed zen via flatpak and you have this issue, you can unset the theme specifically for it by doing something like sudo flatpak override io.github.zen_browser.zen --env=GTK_THEME=“”.

Although this fixed this contrast issue for me, the context menu doesn't seem to follow the browser theme.

fancypantalons commented 1 month ago

I had a very similar issue on my Debian testing install, but with light mode instead. In my case I had to override the theme to specify Adwaita. i.e. in my .desktop files (I'm using the appimage), I had to change the Exec line to:

env GTK_THEME="adwaita" /my/home/.local/share/AppImage/ZenBrowser.AppImage
eifr commented 1 month ago

for some reason, this worked:

flatpak override --user --env=GTK_THEME=Breeze

I guess flatpak didn't pickup the theme before (im on kde plasma)

dosubot[bot] commented 4 days ago

Hi, @henoktx. I'm helping the desktop team manage their backlog and am marking this issue as stale.

You've reported an issue regarding poor text contrast in the context menu of the Zen application while using dark mode on Linux, which has affected readability. Several users, including Yasir-Zafar and pokhrelashok, have confirmed similar experiences, particularly with Flatpak installations. Solutions discussed include switching to the binary version of Zen or adjusting GTK theme settings, with navoyan providing a command to unset the theme for Flatpak installations.

Could you please let us know if this issue is still relevant to the latest version of the desktop repository? If it is, feel free to comment here to keep the issue open. Otherwise, you can close it yourself, or it will be automatically closed in 7 days. Thank you!

fancypantalons commented 2 days ago

Just updated and I can confirm this issue is present in version 1.0.1-a.17 on Gnome 47 (Wayland on Debian Trixie) using the appimage. Same workaround applies for me (manually forcing the GTK theme to Adwaita before launching).

dosubot[bot] commented 2 days ago

@mauro-balades, the user has confirmed that the issue with poor text contrast in the context menu while using dark mode on Linux is still present in version 1.0.1-a.17. Could you please assist them with this?