HDR playback does not work properly on macOS

zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!

https://zen-browser.app

Mozilla Public License 2.0

12.47k stars 295 forks source link

HDR playback does not work properly on macOS #496

Closed miklosakos closed 1 week ago

miklosakos commented 3 weeks ago

What happened?

Loading a video in HDR on YouTube, like Jacob + Katie Schwarz's COSTA RICA IN 4K 60fps HDR (ULTRA HD) will start playing back in HDR, however the actual video looks like HDR content being played back on an SDR display. This bug does not happen on Mozilla Firefox running on macOS.

Reproducible?

[X] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.0-a.28 (64-bit)

Severity impact

Medium

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

HarryHeres commented 2 weeks ago

Same issue, will take a look into it and see if I can find the culprit. Confirming that HDR with normal Firefox works.

HarryHeres commented 2 weeks ago

Can confirm, one of the git patches in src folder is causing this. Pin-pointing this down further later today...

mauro-balades commented 2 weeks ago

I wonder what it could be

HarryHeres commented 2 weeks ago

I wonder what it could be

I'm quite interested as well, but I'm close to figuring it out.

HarryHeres commented 2 weeks ago

Can confirm that the issue remains with the clip-path and overflow:hidden attributes (used for rounded borders) of the content window.

A viable solution (for now) is to use https://zen-browser.app/themes/c6813222-6571-4ba6-8faf-58f3343324f6.

HarryHeres commented 1 week ago

@mauro-balades I think this can get closed for now as we have a solution. I might get back to this later, but I think there are other issues with higher priority.