"Close Tabs to Right/Left" in vertical tabs

zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!

https://zen-browser.app

Mozilla Public License 2.0

12.17k stars 289 forks source link

"Close Tabs to Right/Left" in vertical tabs #521

Open BramLeisink opened 2 weeks ago

BramLeisink commented 2 weeks ago

What happened?

It is showing "Close Tabs to Right" or "Close Tabs to Left" in the "Close Multiple Tabs" menu. This text should be changed to something like "Close Tabs Above/Below", because of the vertical tabs. I don't remember having this bug before I updated to the newest version.

Reproducible?

[ ] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.0-a.28

Severity impact

Low

What platform are you seeing the problem on?

Linux

Relevant log output

No response

Zykkl commented 2 weeks ago

Correct me if I'm mistaken, but this seems like a small change in the localization packs, right? If so, I'd look into it. I'm not sure how I'd do with the other languages, but that's a different issue

BramLeisink commented 2 weeks ago

I definitely think the issue is related to the localization packs, as the text changed at the same time those packs were created. However, I don't believe it's as simple as just modifying the packs—though I could be overlooking something.

Could this be related to the issue? https://github.com/zen-browser/l10n-packs/blob/cba2da16c3aaee9d2e239204b66fef3dfececd74/en-US/browser/browser/zen-vertical-tabs.ftl