search

zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
16.8k stars 395 forks source link

Gecko RTX HDR for video not working #634

Open Stryxus opened 2 months ago

Stryxus commented 2 months ago

What happened?

Gecko pretty much just introduced support for NVIDIA's RTX HDR for videos but, for some reason this does not work under Zen Browser. This is pretty vital for us with HDR monitors since, for the time being at least, there is no native HDR at all in Gecko.

Reproducible?

Version

1.0.0-a.29

Severity impact

Medium

What platform are you seeing the problem on?

Windows

Relevant log output

No response

HarryHeres commented 2 months ago

Try to enable the following settings in about:config and restart the browser:

More info here: https://connect.mozilla.org/t5/ideas/add-firefox-support-for-rtx-video-super-resolution/idi-p/26995/page/5

Stryxus commented 2 months ago

Try to enable the following settings in about:config and restart the browser:

* `gfx.webrender.overlay-vp-auto-hdr`

* `gfx.webrender.overlay-vp-super-resolution`

More info here: https://connect.mozilla.org/t5/ideas/add-firefox-support-for-rtx-video-super-resolution/idi-p/26995/page/5

Both are enabled by default.

HarryHeres commented 2 months ago

If you turn them off, does HDR generally work? I'm working on a fix for https://github.com/zen-browser/desktop/issues/496, so I'm wondering if this is related.

Stryxus commented 2 months ago

If you turn them off, does HDR generally work? I'm working on a fix for #496, so I'm wondering if this is related.

Sadly, no change, even with a mix of them on and off.

HarryHeres commented 2 months ago

Then this might get fixed alongside #496

HarryHeres commented 2 months ago

@Stryxus could you try using https://zen-browser.app/themes/c6813222-6571-4ba6-8faf-58f3343324f6 to see if it is related or not?

mauro-balades commented 2 months ago

Yeah, could you try with that theme enabled?

Stryxus commented 2 months ago

@Stryxus could you try using https://zen-browser.app/themes/c6813222-6571-4ba6-8faf-58f3343324f6 to see if it is related or not?

This didn't change anything, tested with mix's of the flags also.

HarryHeres commented 1 month ago

@Stryxus Is this still relevant? Try updating to a more recent version of the browser.

Stryxus commented 1 month ago

Yea, its still relevant. Through all settings.

HarryHeres commented 1 month ago

This is weird. As far as I can tell, HDR should be working without any issues as Firefox supports it. As I'm understanding that correctly, you're not able to get "regular" nor "NVIDIA RTX" HDR working ,right?

Stryxus commented 1 month ago

This is weird. As far as I can tell, HDR should be working without any issues as Firefox supports it. As I'm understanding that correctly, you're not able to get "regular" nor "NVIDIA RTX" HDR working ,right?

Regular HDR isnt supported by Firefox other than on macOS. RTX HDR doesnt work at all on the latest Zen build with combinations of the HDR flags/settings.

HarryHeres commented 1 month ago

Ah, I see. Thank you for the clarification.

umarhamzy commented 1 month ago

The issue still persists, super resolution still doesn't kick in.

Robot-Inventor commented 4 weeks ago

I don't have an HDR display, so I haven't been able to verify RTX HDR, but I was able to get Video Super Resolution working by setting gfx.webrender.dcomp-video-hw-overlay-win-force-enabled to true. This setting might also enable RTX HDR to function as well.

BronzeManul commented 4 days ago

I don't have an HDR display, so I haven't been able to verify RTX HDR, but I was able to get Video Super Resolution working by setting gfx.webrender.dcomp-video-hw-overlay-win-force-enabled to true. This setting might also enable RTX HDR to function as well.

Chiming in on this because this issue literally almost made me revert my decision to switch from Chrome. I was having the exact same issues described by Stryxus - RTX HDR inactive, regardless of flags, having the rounded corners extension, etc.

Just tried what Robot-Inventor suggested, setting gfx.webrender.dcomp-video-hw-overlay-win-force-enabled to true. This was partially successful, but I now get some weird behaviour: