URL bar pill doesn't change shape when searching

zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!

https://zen-browser.app

Mozilla Public License 2.0

12.21k stars 289 forks source link

URL bar pill doesn't change shape when searching #721

Closed notsatvrn closed 2 weeks ago

notsatvrn commented 2 weeks ago

What happened?

Some websites have additional emblems such as permissions after the HTTPS icon in the URL bar. When this occurs, the right side of the bar pill loses it's roundness so the two sections can merged into one block.

Unfortunately, when deleting the URL and beginning a search from a site where this occurs, the pill does not return to it's original shape.

Reproducible?

[X] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.0-a.29

Severity impact

Low

What platform are you seeing the problem on?

Linux

Relevant log output

No response

notsatvrn commented 2 weeks ago

I should also note, this behavior isn't just visible on websites with the additional permissions icon. That wasn't immediately apparent to me because on those sites it didn't have the ugly right side unrounded behavior to carry over.

KiKaraage commented 2 weeks ago

Yeeeeeees. Noticed this too.

notsatvrn commented 2 weeks ago

Working on a PR for this issue as well as some other tiny inconsistencies that bothered me.

notsatvrn commented 2 weeks ago

At this point I'm convinced the only way to fix the shape issue when the permissions box is present is to separate it from the first box or make it invisible in the extended search box. I've tried a number of CSS selectors to detect when the box is no longer visible but still present, nothing seems to be working.

EDIT: Figured it out using the browser toolbox. Will be submitting a PR soon.