Brower cannot be started if built. [linux]

[Autumnlight02]

What happened?

I basically pulled it, ran the build and I continuesly get the following error:

I ran the bootstrap command, the build command and then start

Reproducible?

• [X] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.0

Severity impact

High

What platform are you seeing the problem on?

Linux

Relevant log output

[autumnlight@autumnlight]npm run start

> zen-core@1.0.0 start
> cd engine && ./mach run --noprofile

 0:00.43 /var/home/autumnlight/Documents/github/personal/zen-browser/desktop/engine/obj-x86_64-pc-linux-gnu/dist/bin/zen -no-remote
JavaScript error: resource://gre/modules/ShortcutUtils.sys.mjs, line 142: TypeError: keyAttribute is null
console.info: "ZenThemeImporter: Initiating Zen theme importer"
console.info: "ZenThemeImporter: Zen theme imported"
console.info: "ZenWorkspaces: Initializing ZenWorkspaces..."
JavaScript error: chrome://browser/content/tabbrowser/tabbrowser.js, line 6064: TypeError: this.selectedBrowser is undefined
console.info: "ZenWorkspaces: ZenWorkspaces initialized"
JavaScript error: , line 0: uncaught exception: undefined
JavaScript error: , line 0: uncaught exception: undefined
JavaScript error: resource:///modules/sessionstore/SessionStore.sys.mjs, line 2749: TypeError: browser is undefined
console.info: "ZenThemeModifier: init browser layout"
console.info: "Zen CKS: Initializing shortcuts"
JavaScript error: chrome://browser/content/tabbrowser/tabbrowser.js, line 6064: TypeError: this.selectedBrowser is undefined
JavaScript error: chrome://browser/content/tabbrowser/tabbrowser.js, line 6071: TypeError: this.selectedTab is undefined
JavaScript error: resource:///modules/UrlbarInput.sys.mjs, line 3669: TypeError: this.window.gBrowser.selectedBrowser is undefined
JavaScript error: resource:///modules/ReportBrokenSite.sys.mjs, line 389: TypeError: tabbrowser.selectedBrowser is undefined
console.info: "ZenThemeModifier: set tabs max-height to" "577.6666870117188px"
JavaScript error: chrome://browser/content/tabbrowser/tabbrowser.js, line 6071: TypeError: this.selectedTab is undefined
JavaScript error: resource:///modules/UrlbarInput.sys.mjs, line 1965: TypeError: WeakMap key undefined must be an object

...  (many times the following)
Assertion failure
assert@resource:///modules/AsyncTabSwitcher.sys.mjs:505:36
preActions@resource:///modules/AsyncTabSwitcher.sys.mjs:572:10
handleEvent@resource:///modules/AsyncTabSwitcher.sys.mjs:1095:12
Assertion failure

[Autumnlight02]

[mauro-balades]

Hi, you need to run sh scripts/update-en-US-packs.sh and start again

[LeMoonStar]

Hi, you need to run sh scripts/update-en-US-packs.sh and start again

When doing the following:

git pull
git submodule update
pnpm run init
pnpm run build
sh scripts/update-en-US-packs.sh
pnpm run start

The same problem occurs.

I am now re-building, having run the script before the build - Will report once I get the results.

[LeMoonStar]

I can report: running sh scripts/update-en-US-packs.sh after the init and before the build works.

If this isn't going to be added to the build scripts any time soon, it should probably be included in the build instructions.

[mauro-balades]

We are currently reworking the docs right now

[HarryHeres]

Can confirm that sh sripts/update-en-US-pack.sh needs to be run after npm run init and before npm run build in order for the browser to be able to work properly on MacOS.

I second @LeMoonStar 's idea to include in in the build scripts.

[mauro-balades]

Or just include the update-en-US-pack to the "init" command yeah

[HarryHeres]

Or just include the update-en-US-pack to the "init" command yeah

Yup! Want me to implement that? Would love to help out with the development :)

[LeMoonStar]

I wonder, when building, shouldn't all languages be included?

I know the download-language-packs.sh does run the update script on all languages, BUT it also changes global git configuration and should either probably not be used by anybody (except for Github actions) or be rewritten to not have such side effects.

[HarryHeres]

I wonder, when building, shouldn't all languages be included?

I know the download-language-packs.sh does run the update script on all languages, BUT it also changes global git configuration and should either probably not be used by anybody (except for Github actions) or be rewritten to not have such side effects.

Good point