zen-browser / theme-store

🎨 Theme repository for @zen-browser!
https://zen-browser.github.io/theme-store/themes.json
MIT License
124 stars 37 forks source link

Add theme: Workspace Seperator #333

Open mauro-balades opened 2 months ago

mauro-balades commented 2 months ago

Add theme: Workspace Seperator

This PR adds a new theme to the theme library.

Theme Details

mauro-balades commented 1 month ago

Id recomend adding a bottom: var(--space-small); attribute instead of a transform

HliasOuzounis commented 1 month ago

With the bottom, the line gets placed at the bottom of the screen instead of below the workspace button but I'm not well versed with css to know a better way to do this. I agree that the translateY is ugly.

I should also remove the images from the readme.me file. Should I clone this repo, make the changes and push? Will it mess with the bot?

mauro-balades commented 1 month ago

You can directly change it from the https://github.com/zen-browser/theme-store/tree/create-theme-332 branch... No need to clone anything, I think you can just do it from the github website, as you like 😅

HliasOuzounis commented 1 month ago

Unfortunately, since I don't have write access I had to fork this branch -> make changes -> create new pull request (#355) onto #332

mauro-balades commented 1 month ago

Does this theme work without the legacy toolbar option?

HliasOuzounis commented 1 month ago

image It should work just fine.

But I'm realizing that it's a very niche change and I could probably just keep it as a local theme for my machine...

ProbablyM-S commented 1 month ago

its redundant now workspace dont look like this anymore this can be closed?