zen-mod / ZEN

Zeus enhancement mod for Arma 3
https://zen-mod.github.io/ZEN
GNU General Public License v3.0
108 stars 47 forks source link

Deep copy/paste does not retain ACE Traits #645

Open YetheSamartaka opened 2 years ago

YetheSamartaka commented 2 years ago

Arma 3 Version: 2.06.148221 CBA Version: 3.15.6.211004 ZEN Version: 1.12.0

Mods:

- CBA_A3
- ace
- Zeus Enhanced
- Zeus Enhanced - ACE3 Compatibility

Description: Deep copy/paste does not retain ACE Traits (Such as Medical Training, Engineering Skill and Explosive Specialist).

Expected behavior: ACE Traits are also copied and applied on new unit.

Steps to reproduce:

  1. Have an unit with some ACE Traits
  2. Deep copy and paste said unit
  3. Inspect copied unit and see that ACE Traits are set to None or No.

Where did the issue occur?

Additional information:

RPT log file:

Screenshots: Original unit: Original Unit Deep pasted unit(Which does not have the same ACE Traits as it should): Deep pasted unit

Kexanone commented 2 years ago

The traits are stored as variables in the unit's namespace. Question is whether we want to serialize them manually or if we go for a more general approach and just serialize all variable in the unit's namespace.

YetheSamartaka commented 2 years ago

The traits are stored as variables in the unit's namespace. Question is whether we want to serialize them manually or if we go for a more general approach and just serialize all variable in the unit's namespace.

All variables could be dangerous. I'd go for a more focused approach.