zen-mod / ZEN

Zeus enhancement mod for Arma 3
https://zen-mod.github.io/ZEN
GNU General Public License v3.0
108 stars 47 forks source link

Add Advanced Rappelling compatibility #700

Closed Kexanone closed 1 year ago

Kexanone commented 1 year ago

When merged this pull request will:

Kexanone commented 1 year ago

To Do: Get reinforcements working

mharis001 commented 1 year ago

Maybe these should be two separate waypoints (Fastrope and Advanced Rappel) because the mods could be run together. We could add conditions to waypoints so that they only show if the required mods are loaded.

Kexanone commented 1 year ago

Sounds like a good alternative approach. Would you propose the AR waypoint in a compat. or part of the main addon? If I remember correctly we decided against having anything but ACE as soft dependency in the main addon, that's why I went the compat. route in the first place.

mharis001 commented 1 year ago

Yeah, I think we can revisit that decision for some other big mods. I think both a new component (separation of features/responsibilities) or just in the ai component are good options. With waypoint conditions, this feature could be added without a hard dependency.

mharis001 commented 1 year ago

I separated out the waypoints into "Fastrope" and "Rappel" and reworked how reinforcements handles the different insertion methods for air vehicles. I think we should keep the Advanced Rapelling compatibility as a separate optional component.

mharis001 commented 1 year ago

@Kexanone, I think this is good to go. Please look over my changes and merge when ready.

Kexanone commented 1 year ago

Looks good to me, but still needs to be tested if you haven't already.

mharis001 commented 1 year ago

I did the usual testing, and everything seemed okay. I think we are good to merge.