search

zen-mode / Whatsapp-Zen-Mode

MIT License
7 stars 8 forks source link

Visiblity Schedule should only Save preferences when someone clicks OK #225

Closed ripper234 closed 2 years ago

ripper234 commented 2 years ago

When someone clicks "X" to close the config window for Vis Schedule, instead of clicking OK:

  1. If the user didn't make any changes, the window should close silently (like today).
  2. If the user made any changes, then a popup should pop up "Discard your changes?"

Motivation - X should not save the changes. The user should have a way to quit without saving changes.

TODO - specify this feature further.

liatzionimorad commented 2 years ago

@IvanTotti fixed in 21 please check

IvanTotti commented 2 years ago

@liatzionimorad Preferences are saved only after the user clicks OK, but the mentioned point number 2. If the user made any changes, then a popup should pop up "Discard your changes?" is not appearing

IvanTotti commented 2 years ago

Tested, Everything is working fine.