Improvement on the default python test template

zen0wu / topcoder-greed

greedy editor for topcoder arena

Apache License 2.0

229 stars 45 forks source link

Improvement on the default python test template #29

Closed wookayin closed 11 years ago

wookayin commented 11 years ago

Hello, again!

The previous pull request #28 added an initial working of python support feature, and this one addes some improvements on the default test code.

Changes summarized:

Improve equal operator (to handle tuple/list types, as well as real-valued numbers)
Fix a compilation error when the parameters or the expected value is an empty tuple
Typo fix, and a vim-friendly marker is added :)

Please review on this, and after merged I will work on some kind of refactoring to eliminate duplicated codes, making this feature being closed.

zen0wu commented 11 years ago

Amazing work! Thanks @wookayin I participated last SRM and Arena's Python support was suddenly disabled during the contest. It seems unstable. I wonder how did you test these?

wookayin commented 11 years ago

@shivawu We can use python on practice rooms. I also wanted to test it on the real-event SRM, but neither could I. Maybe next time:) Still, we can test the plugin on lots of practice rooms.

wookayin commented 11 years ago

@shivawu, thanks for your supporting. However, it just came to my mind that I forgot to submit a patch for the forementioned bug; the recent release of 1.5 has it. Would it be ok?

zen0wu commented 11 years ago

@wookayin You can submit it right now and I can update the 1.5 version, I assume there should be no one have downloaded the 1.5 version.