search

zen0wu / topcoder-greed

greedy editor for topcoder arena
Apache License 2.0
229 stars 45 forks source link

Log directory name becomes 'null'. #86

Closed wookayin closed 10 years ago

wookayin commented 10 years ago

Under the bleeding edge version of the Greed, when log is enabled, we have a directory null in the root of the workspace, as well as Logs. This seems to be a log folder - something became null in our codes.

./Logs/greed-11-30.log
./null/greed-11-30.log

I will inspect the cause later.

wookayin commented 10 years ago

LoggingConfig.logFolder is occasionally null.

zen0wu commented 10 years ago

So this is caused by LoggingConfig.logFolder = null right?

zen0wu commented 10 years ago

I cannot reproduce this problem, could you be specific on the problem?

vexorian commented 10 years ago

It has happened to me. It happens very randomly and have no idea how I could tell you to reproduce it. You enable log folder, develop/test greed as usual and some odd day you'll notice a subfolder called "null" in your greed folder, containing logs. Usually it is few log lines.

zen0wu commented 10 years ago

Now I'm guessing the reason why this happen is when there's invalid configurations, and the parser will throw exception, but I'm not really sure yet.

I've changed the logging behaviour in commit 183790ea3418aed1ebb0ab4a3235e604b2844549, and also in the commit ddc7ef1 which changes the initialzation logic, and I think this bug should be resolved now.

Let's keep this for a while, and will close this before the release.

vexorian commented 10 years ago

It makes sense it has something to do with invalid configuration as @wookayin and I possibly tend to tweak the configuration and cause invalid config issues frequently.

ashashwat commented 10 years ago

I have seen it happening very rarely with 2.0 beta [due to the invalid config], but I have not seen it in 2.0 RC yet.

wookayin commented 10 years ago

I can't see it happening any more. Closing the issue (let's re-open if it re-happens).