search

zenangst / Family

:children_crossing: A child view controller framework that makes setting up your parent controllers as easy as pie.
Other
250 stars 10 forks source link

Improve lookup performance by using attributes #138

Closed zenangst closed 5 years ago

zenangst commented 5 years ago

This PR optimizes the previous improvements to the render method by using the attribute variable for looking up padding and margins. It essentially removes redundant type-casting in methods that need to be lightning fast.

codecov-io commented 5 years ago

Codecov Report

Merging #138 into master will decrease coverage by 0.4%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   83.96%   83.55%   -0.41%     
==========================================
  Files          11       11              
  Lines         823      827       +4     
==========================================
  Hits          691      691              
- Misses        132      136       +4
Flag Coverage Δ
#iOS 65.59% <0%> (-2.95%) :arrow_down:
#macOS 83.55% <0%> (-0.41%) :arrow_down:
#tvOS 65.59% <0%> (-2.95%) :arrow_down:
Impacted Files Coverage Δ
Sources/Shared/FamilySpaceManager.swift 50% <0%> (-8.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f142cf...af17468. Read the comment docs.