search

zenangst / Family

:children_crossing: A child view controller framework that makes setting up your parent controllers as easy as pie.
Other
250 stars 10 forks source link

Multiple UICollectionViews inside FamilyViewController will be jumpy when scrolling #152

Closed superk589 closed 5 years ago

superk589 commented 5 years ago

ezgif-4-8878a7150142 This new issue only occurs on real devices. (The device above is iOS 12.4, iPhone X) When a collection view with more than one screen items followed by a new collection view with fewer items, the first collection view will be jumpy. Use demo code here(the newest commit): https://github.com/superk589/FamilyDemo

zenangst commented 5 years ago

@superk589 I'll investigate this when I get to the office today, thanks for creating the demo, it helps a lot for debugging!

zenangst commented 5 years ago

@superk589 hey mate, I need to get ahold of a device to test on to verify this. However, I did find another issue that I fixed, it could contribute to the behavior that you are seeing. Would you mind trying this branch?: fix/recursion-bug

superk589 commented 5 years ago

@zenangst I've tried fix/recursion-bug, but it doesn't help. This time it becomes jumpy not only on real devices but also on simulators.

zenangst commented 5 years ago

Gonna do some additional work on this, still commuting to work. I’ll keep you posted! ;)

zenangst commented 5 years ago

At work now, starting to debug… however I'm not seeing what you are seeing at the moment.

zenangst commented 5 years ago

Oh, I was just able to reproduce this… let's smash this bug! 🔨

zenangst commented 5 years ago

@superk589 I think I found the issue now, mind trying the fix/rounding-issue-in-layout-algorithm branch?

superk589 commented 5 years ago

@zenangst Just tried fix/rounding-issue-in-layout-algorithm, I think it has been fixed.

zenangst commented 5 years ago

Very nice, I'll merge it into master and make a new version. Thanks for reporting this and following up!