search

zenangst / Family

:children_crossing: A child view controller framework that makes setting up your parent controllers as easy as pie.
Other
250 stars 10 forks source link

viewWillAppear isn't called on UICollectionViewController child #189

Closed zocario closed 4 years ago

zocario commented 4 years ago

Hello,

I have a new issue, this time when using an UICollectionViewController as child controller :)

Steps to reproduce:

  1. Create a FamilyViewController containing a view controller subclassing UICollectionViewController
  2. Present the controller

Whats happens: The viewWillAppear method isn't called on the UICollectionViewController subclass.

What should happens: viewWillAppear should be called correctly.

I've found a workaround by creating an UIViewController containing an UICollectionView, then it's working correctly.

Sample: Test family collection view.zip

zenangst commented 4 years ago

@zocario Hey mate, yeah that seems odd. Thanks for the sample project, helps a lot with debugging 😄 I'm gonna do some digging when life allows 😎

zenangst commented 4 years ago

@zocario figure out what was going wrong here. I made a PR here #190

If you can try the branch fix/collection-view-controllers-view-life-cycle-issue just to get a second confirmation that this is ok now, that would be awesome! ❤️

Again, thanks for the sample project, it made it super easy to test, debug and fix! Cheers 🍻

zocario commented 4 years ago

@zenangst Wow that's was fast! I checked the issue with your branch and yes viewWillAppear was called so it is looking good :)

Cheers 🍻 and thank you 🤗

zenangst commented 4 years ago

I'll merge and make a new version!

zenangst commented 4 years ago

@zocario version 1.1.1 has been pushed to CocoaPods now, you reckon we can close this issue now?

zocario commented 4 years ago

Yes I close the issue :)