search

zenangst / Family

:children_crossing: A child view controller framework that makes setting up your parent controllers as easy as pie.
Other
250 stars 10 forks source link

Fix collection view controllers life cycle issue #190

Closed zenangst closed 4 years ago

zenangst commented 4 years ago

Because UICollectionViewController's view is an internal class (UICollectionViewControllerWrapperView), we need to cherry-pick by adding the collection view as the view that goes into FamilyScrollView and prepend the view controllers view (the internal class) to the bottom of the hierarchy so that it doesn't cover up the FamilyScrollView.

codecov-commenter commented 4 years ago

Codecov Report

Merging #190 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   80.11%   80.11%           
=======================================
  Files          11       11           
  Lines         835      835           
=======================================
  Hits          669      669           
  Misses        166      166
Flag Coverage Δ
#iOS 43.00% <ø> (ø)
#macOS 80.11% <ø> (ø)
#tvOS 43.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec055af...f364118. Read the comment docs.