search

zenangst / Gray

:first_quarter_moon: Tailor your macOS Mojave experience
https://github.com/zenangst
Other
1.33k stars 46 forks source link

Application Names not Correct #109

Closed L1cardo closed 4 years ago

L1cardo commented 4 years ago

Now I see that the Gray takes the application names from executableName, and it is a little annoying in Chinese . Some application‘s name is different from their executableName. Is it possible to just display the application name instead of executableName? I know that executableName is written in the info.plist file, and info.plist is written by the application builder, but can it be possible ? image image

zenangst commented 4 years ago

Hey @L1cardo, thanks for bringing this to my attention. I'll see what I can do 😎

zenangst commented 4 years ago

Hey @L1cardo, just wanted to give you a quick update on this issue. I've implemented a very basic parser for this and tried it out. Here is the result with WeChat when I force a specific locale.

Screen Shot 2019-10-25 at 21 49 17

I should be able to have a new version out shortly with support for localize application names. Again, thanks a bunch for bringing this to my attention, I'm just a crazy Swed, living in Norway with my system locale set to English so I don't run into these kinds of situations myself. Thanks for making Gray even better!

I'll keep you updated when a new version is available for download, cheers! 🍻

L1cardo commented 4 years ago

The gratefulness should be mine!
Thanks for developing such an awesome app! And thank for what you have done, not just or me or for Chinese users, but for all the community! By the way, do you know that you are the most kind and most modest programmer that I have ever know !

zenangst commented 4 years ago

Hey @L1cardo, thank you so much for the kind words!

I've created a PR to add an initial implementation for resolving a localized name for applications. You can find the PR here https://github.com/zenangst/Gray/pull/110. Are you able to build the project and make a version that you can test locally or do you want me to provide a binary? If the latter, then I can probably fix one for you later this evening, cheers!

zenangst commented 4 years ago

Here is a notarized version of the application with the localization fix, please take it for a spin and report back to me.

Gray.zip

L1cardo commented 4 years ago

I tested the build above, and I found two issues.

  1. Apps can not be searched by their Chinese names. image image

  2. System Apps are still in English. image

zenangst commented 4 years ago

Thanks for reporting back, totally forgot about search. I’ll push some new commits when life allows ;)

zenangst commented 4 years ago

@L1cardo mind trying this new binary to see if it doesn't work better :)

Gray.zip

L1cardo commented 4 years ago

I am in class and I will test it later, thanks for your hard work!

zenangst commented 4 years ago

Be cool, stay in school 😎

L1cardo commented 4 years ago

Emmmm, are you sure this is the new version ? The localized app names are missing in this build image

zenangst commented 4 years ago

This is why I shouldn't program before I've had my coffee 😆 I'll do some further investigation, I'll keep you posted.

L1cardo commented 4 years ago

Hahaha, enjoy your coffee!

L1cardo commented 4 years ago

@zenangst Hi, how are you! I have tested 0.16.0 version and all things are extremely good in Chinese !! A huge thanks to you !!!

zenangst commented 4 years ago

Closing this now :) Cheers 🍻