Improve/application parsing

zenangst / Gray

:first_quarter_moon: Tailor your macOS Mojave experience

https://github.com/zenangst

Other

1.34k stars 46 forks source link

Improve/application parsing #53

Closed zenangst closed 5 years ago

zenangst commented 5 years ago

Removes special case for adding Finder to the list of applications
Improves how applications are filtered out from the list of applications

Applications that don't show up on the list are excluded because of the following reasons.

Their application name includes any of the excluded keywords

let excludeKeywords = [
  "handler", "agent", "migration",
  "problem", "setup", "uiserver",
  "install", "system image", "escrow"]

The application is lacking an icon
Uses Electron

JayBrown commented 5 years ago

Question: is it wise to exclude applications without icons? I'm wondering if it's possible to have an application without an icon that's still dark-mode compatible; case in point would be SlowQuitApps: https://github.com/dteoh/SlowQuitApps … or does that exclusion only apply to CoreServices?

zenangst commented 5 years ago

Right now it covers all applications, not just the ones found in CoreServices. Maybe scoping the filter to that folder would be a good improvement. I'm gonna try that

zenangst commented 5 years ago

@JayBrown refactored the code now, I think it should be good to go.