search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Fix injection bug in ComponentManager #798

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This fixes a dependency injection bug in ComponentManager when passing configuration to the controller.

Note to self: start with dependency injection! 😁

codecov[bot] commented 6 years ago

Codecov Report

Merging #798 into master will increase coverage by 0.85%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #798      +/-   ##
=========================================
+ Coverage   84.54%   85.4%   +0.85%     
=========================================
  Files         152     152              
  Lines       10378   10378              
=========================================
+ Hits         8774    8863      +89     
+ Misses       1604    1515      -89
Flag Coverage Δ
#ios 83.42% <100%> (ø) :arrow_up:
#osx 86.63% <100%> (ø) :arrow_up:
#tvos 74.68% <100%> (-7.89%) :arrow_down:
Impacted Files Coverage Δ
Sources/Shared/Classes/ComponentManager.swift 95.12% <100%> (ø) :arrow_up:
...urces/iOS/Extensions/Delegate+iOS+Extensions.swift 90.12% <0%> (+1.23%) :arrow_up:
SpotsTests/iOS/ComponentDelegateiOSTests.swift 84.81% <0%> (+3.79%) :arrow_up:
...es/iOS-Exclusive/Classes/SpotsScrollView+iOS.swift 100% <0%> (+11.76%) :arrow_up:
...potsTests/Shared/ComponentFocusDelegateTests.swift 86.36% <0%> (+86.36%) :arrow_up:
SpotsTests/tvOS/SpotsScrollViewTVOSTests.swift 100% <0%> (+100%) :arrow_up:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 100% <0%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 774d47b...96f80e4. Read the comment docs.