search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Feature new delegate methods for header and footer views #801

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This PR adds two new delegate methods that can be used to hook up delegates for header and footer views. It is called when ever the header or footer have been configured inside the component.

zenangst commented 6 years ago

@vadymmarkov fastest review in history. 19 seconds :)

codecov[bot] commented 6 years ago

Codecov Report

Merging #801 into master will increase coverage by 0.88%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   84.48%   85.37%   +0.88%     
==========================================
  Files         152      152              
  Lines       10393    10399       +6     
==========================================
+ Hits         8781     8878      +97     
+ Misses       1612     1521      -91
Flag Coverage Δ
#ios 87.94% <77.77%> (+4.58%) :arrow_up:
#osx 86.59% <66.66%> (+0.01%) :arrow_up:
#tvos 83.54% <77.77%> (+1.03%) :arrow_up:
Impacted Files Coverage Δ
...ared/Extensions/ComponentDelegate+Extensions.swift 14.28% <0%> (-5.72%) :arrow_down:
...ces/Shared/Extensions/Component+HeaderFooter.swift 80% <87.5%> (+2.22%) :arrow_up:
Sources/macOS/Classes/Component.swift 75.56% <0%> (+0.9%) :arrow_up:
...urces/iOS/Extensions/Delegate+iOS+Extensions.swift 90.12% <0%> (+1.23%) :arrow_up:
SpotsTests/iOS/ComponentDelegateiOSTests.swift 84.81% <0%> (+3.79%) :arrow_up:
Sources/iOS/Classes/DefaultItemView.swift 87.09% <0%> (+6.45%) :arrow_up:
...es/iOS-Exclusive/Classes/SpotsScrollView+iOS.swift 100% <0%> (+11.76%) :arrow_up:
...potsTests/Shared/ComponentFocusDelegateTests.swift 86.36% <0%> (+86.36%) :arrow_up:
SpotsTests/tvOS/SpotsScrollViewTVOSTests.swift 100% <0%> (+100%) :arrow_up:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 100% <0%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef5da82...d4bb4fb. Read the comment docs.